Config di linting condivisibile in CI, manca qualcosa nei controlli?

merefield · 27 Marzo 2025, 7:08am

This is passing in a PR, I would expect it to fail a lint?:

github.com/merefield/discourse-tc-character-count

javascripts/discourse/connectors/after-composer-title-input/show-counts.gjs

95e47348a


      
              return this.args.outletArgs.composer.archetypeId === "private_message"
                ? this.siteSettings.min_personal_message_title_length
                : this.siteSettings.min_topic_title_length;
            }
          
            get missingTitleCharacters() {
              return this.titleRequiredLength - this.args.outletArgs.composer.titleLength;
            }
          
            <template>
              {{log this.args.outletArgs.composer}}
              <CharacterCounts
                @missingReplyCharacters={{this.missingTitleCharacters}}
                @length={{@outletArgs.composer.titleLength}}
                @minimumLength={{this.titleRequiredLength}}
              />
            </template>
          }

Are gjs templates in connector files being missed?

Pretty (ahem) sure I’m using a current config:

github.com/merefield/discourse-tc-character-count

package.json

95e47348a


      
          {
            "private": true,
            "devDependencies": {
              "@discourse/lint-configs": "2.12.0",
              "ember-template-lint": "7.0.1",
              "eslint": "9.22.0",
              "prettier": "3.5.3",
              "prettier-plugin-ember-template-tag": "^2.0.4",
              "stylelint": "16.16.0"
            },
            "engines": {
              "node": ">= 18",
              "npm": "please-use-pnpm",

merefield · 27 Marzo 2025, 7:45am

My bad.

It was as simple as a missing dot on the .template-lintrc.cjs filename

consider using the GitHub - discourse/discourse-theme-skeleton: Template for Discourse themes when setting up new theme components … (although for this one, linting was grandfathered)

Argomento		Risposte	Visualizzazioni
Linting configuration Dev development	5	134	Settembre 11, 2024
Automatically updating themes and plugins to .gjs file format Dev dev-news	6	157	Maggio 30, 2025
Suggestion: enable `eol-last` rule for eslint and ember-template-lint Dev	2	877	Aprile 12, 2021
Is there a way to lint handlebars? Dev	14	2429	Febbraio 18, 2021
Theme lint fails because -- Could not find "@discourse/lint-configs/stylelint" Dev	4	50	Marzo 14, 2025

Config di linting condivisibile in CI, manca qualcosa nei controlli?

Argomenti correlati