Shields.io non riesce a recuperare le statistiche dell'API Discourse

haikalpribadi · 14 Settembre 2019, 1:25pm

Hi everyone,

We’ve had a Discourse shield on our repository for a while now, and it recently stopped working.

If you go to https://shields.io/category/chat and select any Discourse shield, you can enter your discourse domain address and it will show you the shield with the correct statistics. You can try this with meta.discourse.org.

However, when we enter our discourse host address (https://discuss.grakn.ai), for any statistics and for both http/https, it always returns “invalid”.

When a host is not found, Shields.io would return “inaccessible”. Thus we assume “invalid” means it’s accessible but there are access rights issues or invalid responses.

Is it possible that a recent update/upgrade broke something on Discourse statistics API that Shields.io uses?

Thank you so much!

marianord · 15 Settembre 2019, 3:00am

It’s working for me in my site, maybe you’re not setting correctly the protocol? Or the Grakn Discourse has any kind on modification that breaks that endpoint.

gerhard · 15 Settembre 2019, 10:35am

You might want to ask Shields.io about that problem. It works with all other sites I tested, so this isn’t our bug.

haikalpribadi · 15 Settembre 2019, 7:20pm

@marianord that’s exactly my question: where are the “protocols” you’re mentioning? How can they be configured? I’ve not changed any settings.

@gerhard given that shields.io is working for other Discourse sites, it does not seem likely to be an issue on their side. Unless they’re re not reading the output from our site statistics properly - but how can we find out about this? What is the endpoint from Discourse that is used to query the statistics? Perhaps we should start there?

marianord · 15 Settembre 2019, 7:27pm

I’m mentioning http vs https.

max_grakn · 19 Settembre 2019, 11:05am

This happened because our Discourse installation blocked Shields.io’s user agent (Shields.io). This setting is named whitelisted crawler user agents and can be edited at
<discourse_server>/admin/site_settings/category/all_results?filter=crawler

haikalpribadi · 19 Settembre 2019, 11:18am

Interesting! Thank you @max_grakn! We did add Googlebot to the whitelist recently, I think that may be the cause.

@codinghorror are we meant to use Blacklist and Whitelist at the same time? As in, if you add things to whitelist, does that mean everything else is blacklisted (which therefore make the blacklist redundant)?

codinghorror · 19 Settembre 2019, 12:41pm

No, the crawler whitelist is very dangerous, and should only be used carefully per the help text.

User agents of web crawlers that should be allowed to access the site. WARNING! SETTING THIS WILL DISALLOW ALL CRAWLERS NOT LISTED HERE!

barto_95 · 13 Novembre 2020, 10:16am

Ciao, ho lo stesso problema quando un test riceve dati non validi… hai qualche idea?

È tutto a posto ora, è necessario attivare le statistiche anonime in:

Admin → impostazioni → altro → condividi statistiche anonime = Abilitato

e ora funziona correttamente per shields.io

spdegabrielle · 15 Novembre 2023, 6:22pm

Ho lo stesso problema, ma la condivisione di statistiche anonime è già abilitata

[![Racket Discourse](upload://6fa5jbSn04vRLXdubAYmFJt5emf.svg)]

[]

Arkshine · 15 Novembre 2023, 7:41pm

Correlato a:

github.com/discourse/discourse

DEV: Ability to collect stats without exposing them via API

main ← dev/ability-to-collect-stats-without-public-exposing

opened 06:37PM - 13 Oct 23 UTC

AndrewPrigorshnev

+228 -119

This adds the ability to collect stats without exposing them among other stats v…ia API. The most important thing I wanted to achieve is to provide an API where stats are not exposed by default, and a developer has to explicitly specify that they should be exposed (`expose_via_api: true`). Implementing an opposite solution would be simpler, but that's less safe in terms of potential security issues. When working on this, I had to refactor the current solution. I would go even further with the refactoring, but the next steps seem to be going too far in changing the solution we have, and that would also take more time. Two things that can be improved in the future: 1. Data structures for holding stats can be further improved 2. Core stats are hard-coded in the About template (it's hard to fix it without correcting data structures first, see point 1): https://github.com/discourse/discourse/blob/63a0700d45f755d0f432a9075ae7afbed9cd6ab0/app/views/about/index.html.erb#L61-L101 The most significant refactorings are: 1. Introducing the `Stat` model 2. Aligning the way the core and the plugin stats' are registered

È perché alcuni campi sono stati rinominati nella loro forma plurale.

topic_count → topics_count
post_count → posts_count
user_count → users_count
like_count → likes_count

Qualcuno dovrà modificare il codice qui per eseguire il fallback alla forma plurale:

github.com/badges/shields

services/discourse/discourse.service.js

master

import Joi from 'joi'
import { metric } from '../text-formatters.js'
import { nonNegativeInteger, url } from '../validators.js'
import { BaseJsonService, queryParams } from '../index.js'

const schemaSingular = Joi.object({
  topic_count: nonNegativeInteger,
  user_count: nonNegativeInteger,
  post_count: nonNegativeInteger,
  like_count: nonNegativeInteger,
}).required()

const schemaPlural = Joi.object({
  topics_count: nonNegativeInteger,
  users_count: nonNegativeInteger,
  posts_count: nonNegativeInteger,
  likes_count: nonNegativeInteger,
})

const schema = Joi.alternatives(schemaSingular, schemaPlural)

This file has been truncated. show original

spdegabrielle · 20 Novembre 2023, 3:52pm

Ancora non funziona: funziona per qualcun altro?

![Racket Discourse](upload://7asTK98zfWLXRebm11uEN3KPM5N.svg)

BryanV · 6 Dicembre 2023, 5:35pm

È stata aperta una PR qualche giorno fa:

github.com/badges/shields

[Discourse] Update schema keys to use plural form (`topic_count` -> `topics_count`)

master ← joshuacwnewton:jn/9776-fix-discourse-js-schema

opened 08:16PM - 03 Dec 23 UTC

joshuacwnewton

+110 -71

This PR does a simple find and replace to update the Discourse schema to use the… current keys found in https://meta.discourse.org/site/statistics.json, as the older keys now return "Invalid response". > [!NOTE] > I was wondering, though, if the old keys should still be preserved, as to not break backwards compatibility with servers using the old names. > > (I tried finding the source of the change in Discourse's release notes/changelog, but there's surprisingly little information when querying e.g. "statistics.json" or "topic_count"/"topics_count". So, I'm not sure when this change actually took place, and thus it's hard to estimate the likelihood of there being servers out there using the old keys.) > > If we do want to support both sets of keys, then I'm not 100% sure what to do, as I've never written JavaScript before. (I tried reading the Joi docs, and got as far as using `.or()` in the schema definition for each pair of keys + using a `try`/`catch` when creating the `metricIntegrations` object, but I wasn't confident enough to commit that solution before discussing it first.) Fixes #9776.

Ma naturalmente questo cambiamento pone un onere su shields.io per supportare entrambe le versioni (perennemente, immagino) poiché non vi è alcuna garanzia che qualsiasi istanza di Discourse abbia aggiornato o meno, quindi non è così semplice come passare al plurale.

Argomento		Risposte	Visualizzazioni
Is there a nice GH badges (ala shields.io images) design to put in README to link from GitHub to our hosted discourse? Feature	17	5097	Settembre 13, 2019
Discourse CDNs are blocked by privacy badger Site feedback	47	12903	Agosto 15, 2017
Can I use the Discourse API on an officially-hosted instance? Support	1	338	Luglio 9, 2021
Access reports JSON data via Pipedream Development rest-api	2	843	Luglio 28, 2021
Daily Summary Feedback Site feedback feedback	253	7428	Marzo 20, 2026

Shields.io non riesce a recuperare le statistiche dell'API Discourse

Argomenti correlati