Should the install guide tell people to run apt update & apt upgrade first?

merefield · October 29, 2021, 2:16pm

My money is on the additional git pull is unnecessary, because of the code here:

discourse/discourse_docker/blob/8e2ccee0f2989885632c27c7f33a87719d3838ec/launcher#L744

    
      
              ;;
          
          
rebuild)
              if [ "$(git symbolic-ref --short HEAD)" == "master" ]; then
                git branch -m master main
                git fetch origin
                git branch -u origin/main main
                git remote set-head origin -a
              fi
          
          
    if [ "$(git symbolic-ref --short HEAD)" == "main" ]; then
                echo "Ensuring launcher is up to date"
          
          
      git remote update
          
          
      LOCAL=$(git rev-parse HEAD)
                REMOTE=$(git rev-parse @{u})
                BASE=$(git merge-base HEAD @{u})
          
          
      if [ $LOCAL = $REMOTE ]; then
                  echo "Launcher is up-to-date"

which seems to check the local version, updates and restarts the launcher if out of date (and a bunch of other things).

Therefore only this should be necessary on subsequent rebuilds:

cd /var/discourse
./launcher rebuild app

without the redundant git pull.

(NB: always good to dive into the source code so you can be more sure).
(NB#2: have deleted my post above which just added to the confusion).

Topic		Replies	Views
Help .. rebuild app failed Installation	21	3025	April 4, 2018
Installation fails on my Debian server Installation	24	2057	March 18, 2019
I got an error after updating my forked install Installation unsupported-install	36	1789	November 13, 2018
Pups::ExecError: su postgres -c 'psql discourse -c "alter schema public owner to discourse;"' failed with return Installation	29	1734	February 12, 2023
Trouble upgrading from 3.3.0.beta1 to 3.3.0.beta6 Installation	22	113	August 8, 2024

Should the install guide tell people to run apt update & apt upgrade first?

Related Topics