Solutions and cheers appear quite large on user cards

Moin · July 16, 2024, 10:25pm

“Cheers” and “Solutions” are larger than the other information:

This image shows an excerpt from a user card, displaying the user's join date, number of "cheers" or likes received, solutions provided, and preferred pronouns "she/her". (Captioned by AI)

Lilly · July 16, 2024, 10:52pm

Yea looks like there are <h3> header tags around those but not the other labels:

Moin · July 16, 2024, 11:05pm

I think the others were removed in

github.com/discourse/discourse

A11Y: remove heading tags from usercards

discourse:main ← discourse:a11y-heading-usercard

opened 05:53PM - 15 Jul 24 UTC

awesomerobot

+80 -72

This removes the headings (h1, h2, h3) from the user and group cards, headings d…on't make sense in this context because they don't contribute to the overall document structure and can interfere with screenreader navigation. Visual styles here shouldn't change... Before: ![image](https://github.com/user-attachments/assets/2a9fe47c-b234-4e4c-b925-6faa273a0066) After: ![image](https://github.com/user-attachments/assets/ea8da9f1-c3a5-45fe-bc79-716c641c93c5) I did fix a couple of related issues while I was at it... * in the "before" you can see how "cheers" from a plugin wraps to the next line too early, this will no longer be the case * the group cards were attempting to use some custom properties like `--avatar-width` but these were only scoped to the user card, so I added the group-card class there to remedy that * `h3.user-status` was hanging out without a parent selector, so it was destined to cause class name collisions... I moved it to be scoped within `user-card` * added class names to the metadata divs

awesomerobot · July 17, 2024, 7:08pm

I’ve got some follow-up fixes for these in:

A11Y: remove heading tag from usercard stat by awesomerobot · Pull Request #299 · discourse/discourse-solved · GitHub
A11Y: remove heading tag from usercard stat by awesomerobot · Pull Request #148 · discourse/discourse-gamification · GitHub
A11Y: remove heading tag from usercard stat by awesomerobot · Pull Request #117 · discourse/discourse-follow · GitHub

JammyDodger · July 21, 2024, 6:11pm

This topic was automatically closed after 3 days. New replies are no longer allowed.

Topic		Replies	Views
User Cards Feel a Little Taller Than They Really Need to Be UX	2	503	September 29, 2022
User card cut off on desktop UX	4	777	January 24, 2020
The +more badges box is offset on the user card UX	3	643	December 17, 2018
User card going under PM header UX	3	506	January 21, 2020
User card opening outside view UX	0	941	June 27, 2016

Solutions and cheers appear quite large on user cards

Related topics