Il conteggio risolto nel riepilogo mostra valori incorretti

[dr460nf1r3 (Nιƈσ 🐉🔥)]

Hey everyone,

After updating our Discourse instance, we seemingly have incorrect solved amounts when looking at profile summaries. Example:

• Wrong: Profile - dr460nf1r3 - Garuda Linux Forum
• Correct (from profile popup):
  

I already noticed there were a couple of changes lately, including a breaking bug:

@nat

We just moved discourse-solved away from using custom fields into proper tables, and there had been some assumptions made like each post should only be an answer to a topic, or a topic with an answer must point to a non-null post. All these assumptions were thrown out of the window

The correct amounts are obviously still available so there was likely something happening while migrating the data to the new tables?

[nat (Natalie T)]

Thanks for writing in. I’ll have a look.

[nat (Natalie T)]

There are some discrepancies in counting solutions in Discourse where we were including topics and posts that have already been deleted.

Before the migration, we were indicating:

John has 27 solutions because people marked his post as solution 27 times.

This is stored in the UserActions table.

After the migration, we are now counting:

John has 20 solutions because there are 20 topics where his posts are solutions

This is stored in the SolvedTopics table, and has a direct link to an existing, non-deleted topic.

There’s a subtle difference here - in the first scenario there were no validations in checking if the solution post or its topic still existed.

I’ll check in with our team which is the better number to display. Personally I am leaning counting solutions for topics that still exist.

[dr460nf1r3 (Nιƈσ 🐉🔥)]

I’m quite sure that this can’t be the issue — as it would only cause fewer numbers rather than more in some cases, correct? There is another example I have for you:
→ Wrong: Profile - SGS - Garuda Linux Forum
→ Right:

It seems impossible to me that this counting mechanism would more than double the amount of solved post counts. Besides that (of course unconfirmed) I highly doubt that the number of deleted posts was this high in my previous example.

Thanks!

[nat (Natalie T)]

Hmmm yes 485 and 90 are too wide apart.

I believe just found the bug (though the statement about discrepancy I mentioned above is still true) –

In the previous implementation, the solution count in John’s summary is counted by the number of times anyone marked the John’s post as solution

  def solved_count
    UserAction.where(user: @user).where(action_type: UserAction::SOLVED).count
  end

In the new implementation, the solution count in John’s user summary is the number of times John marked a post as solution

  def solved_count
    DiscourseSolved::SolvedTopic.where(accepter: @user).count
  end

This explains the large difference. “solved count” changed definitions from ‘how many times you answered’ to ‘how many times you accepted’.

Will fix the bug, thanks again for the report!

I’ll also update the different counting methods used in profile popup and user summary.

[nat (Natalie T)]

Props to @ondrej for also mentioning Solution badge not working? to me. It looks like some discrepancies were already happening before this migration. Good thing is that we’ll be migrating to a more consistent number across Discourse and our plugins.

[dr460nf1r3 (Nιƈσ 🐉🔥)]

Wonderful, thank you very much!

[nat (Natalie T)]

This is now fixed and standardised - FIX: Standardise the definition of what a solution is by nattsw · Pull Request #352 · discourse/discourse-solved · GitHub