Some user profiles now email summaries every 30 minutes after update

zogstrip · May 27, 2024, 3:38pm

There was indeed an issue with the way we computed the “window” we used to compute the content of the email summaries

It will be fixed by

github.com/discourse/discourse

FIX: correctly compute the window for email summaries

discourse:main ← discourse:fix-digest-since

opened 03:35PM - 27 May 24 UTC

ZogStriP

+25 -1

In https://github.com/discourse/discourse/commit/958437e7ddce6e015725522d25c3f83…27ff4064a we ensured that the email summaries are properly sent based on 'digest_attempted_at' for people who barely/never visit the forum. This fixed the "frequency" of the email summaries but introduced a bug where the digest would be sent even though there wasn't anything new since for some users. The logic we use to compute the threshold date for the content to be included in the digest was ```ruby @since = opts[:since] || user.last_seen_at || user.user_stat&.digest_attempted_at || 1.month.ago ``` It was working as expected for users who were never seen but for users who had connected at least once, we would use their "last_seen_at" date as the "threshold date" for the content to be sent in a summary 😬 This fix changes the logic to be the most recent date amongst the `last_seen_at`, `digest_attempted_at` and `1.month.ago` so it's correctly handling cases where - user has never been seen nor emailed a summary (capped at 1 month) - user has been seen in a while but has recently been sent a summary - user has been sent a summary recently but hasn't been seen in a while Context - https://meta.discourse.org/t/some-user-profiles-now-email-summaries-every-30-minutes-after-update/309485

Topic		Replies	Views
After rebuild: lost email association + digest spam every 6 hours Bug activity-summary	3	1502	February 1, 2016
Can I be notified of new upgrades required of Discourse when using Docker Install? Support	6	569	January 22, 2022
Bigger intervals/ lower frequency for activity summary? Feature activity-summary	6	1135	March 29, 2019
Same email gets sent every day Support	5	748	November 12, 2020
Discourse stopped sending notification emails Support	0	429	September 16, 2020

Some user profiles now email summaries every 30 minutes after update

Related topics