RGJ
(Richard - Communiteq)
2 Aprile 2018, 5:59pm
1
Hey guys,
We were just deploying a few new servers and my conclusion is that the stable branch is lacking a few backports of crucial bug fixes. I don’t have a lot of experience with cherry picking but I can point out the issues in question.
It’s the orientation fix and the backup restore fix.
Any chance of getting those back into the stable branch soon? Anything we can do to help here?
6 Mi Piace
Not sure maybe @tgxworld can see what he thinks.
5 Mi Piace
tgxworld
(Alan Tan)
4 Aprile 2018, 8:58am
3
The fixes for restoring backups taken with the new pg_dump
clients have been back-ported into stable.
4 Mi Piace
tgxworld
(Alan Tan)
Ha separato questo argomento il
4 Aprile 2018, 9:05am
5
A post was merged into an existing topic: Help … rebuild app failed
RGJ
(Richard - Communiteq)
4 Aprile 2018, 6:01pm
6
Thanks for backporting these fixes!
However, it does not work. I have been testing this and restoring the backup is still failing.
I was able to nail it down to this migration that was not backported but which is crucial:
https://github.com/discourse/discourse/blob/10d6101eae2f613f8489754144feaff2324727c5/db/migrate/20180308071922_drop_raise_read_only_function.rb
EDIT I have just double checked and when I add this migration, backup/restore is functioning correctly again.
13 Mi Piace
tgxworld
(Alan Tan)
4 Aprile 2018, 11:23pm
7
Backported as well, thanks for digging into this
15 Mi Piace
RGJ
(Richard - Communiteq)
5 Aprile 2018, 5:50pm
8
And here is the final confirmation that backup/restores are working correctly on stable again!
9 Mi Piace
Thank you for helping us work through this
4 Mi Piace