Steam Onebox Oneboxing Non-boxable Pages

(Jack Slater) #1

If the Onebox tries to onebox a steam page that isn’t an /app/ it’ll do this funky thing and dump a bunch of margin/whitespace into the page:


(Sam) #2

I’ve been meaning to drop a note here about this, it’s come up a few times on my forum during the current Steam sale. :slight_smile:

The issue seems to be that it tries to create the little widget for every page that starts with, but only a specific portion of those ( I think?) will actually work with the widget.

(Jeff Atwood) #3

I see we should fix this @zogstrip.

(Régis Hanol) #4

This will soon be fixed :banana:

(Jack Slater) #5

this just looks like it’s deleting the onebox for steam entirely?

(Jeff Atwood) #6

Let’s see

That is more our standard one box format.

(Sam) #7

Well, sure. The onebox looking like Steam’s was a really nice touch though, I thought.

It’s better that a bunch of steam links aren’t rendered unusable I suppose, but I admit I was hoping the fix was going to be more along the lines of “only use the fancy onebox for actual Steam app store pages” then to not use it altogether.

(Régis Hanol) #8

The thing is with embedded iframes, we have no control over it and they can break anytime. I agree this onebox doesn’t look as sexy as the embedded version but at least it’s consistent.

(Jeff Atwood) #9

It should include the price though I think

(Régis Hanol) #10

It’s unfortunately not something they disclose in their OpenGraph tags. I guess I can restore the embedded version for “{id}/” and use the default onebox for other cases.

(Sam) #11

Fair enough. Thanks for the quick response. It is definitely better to not have a bunch of unusable links. :slight_smile:

If feasible though, the embedded onebox is rather nice on gaming-oriented forums.

(Martial) #12

Whoooo this is a serious regression for gaming community.

There is a big difference between this :

and this :

The commit e12c49b95d0a00427b83ab182712bd605a269742 removes ALL the steam onebox, this is not “unnecessary steam store onebox”

I understand there is a bug but can we check if the url shared have /app/ or /sub/ before use the classical onebox ?

Otherwise I will revert the commit locally since (on my community) steam url shared by user are rarely about something else than app sales (I never notice this bug since no one share a link that is not about an app for example).

just my point a view, but again I do understant the bug and why the special steamonebox was remove.

(Régis Hanol) #13

Don’t worry, I’m adding it back for /app :wink:

(Régis Hanol) #14

Restored the onebox but only for “/app/

(will be deployed here soon)

(Jeff Atwood) closed #15