bartv
(Bart )
9 ديسمبر 2018، 10:49ص
1
Hi,
We just noticed that the subcategories dropdown list now only has a ‘none’ option where it used to also have an ‘all’ option.
Here’s what it looks like now:
Here’s what it looks like on an older installation:
While ‘all’ is still the default value, you can’t return to it after diving into a subcategory, making navigation a little harder. Is this on purpose, or a bug?
إعجابَين (2)
jomaxro
(Joshua Rosenfeld)
9 ديسمبر 2018، 2:23م
2
Good catch, don’t think this is intentional. If you need to get to “all” you can select “none” first, then reopen the filter.
cc @j.jaffeux
إعجابَين (2)
j.jaffeux
(Joffrey Jaffeux)
9 ديسمبر 2018، 4:14م
3
This should fix it, it also introduces tests for category-drop
:
https://github.com/discourse/discourse/pull/6743
Will think more about it and maybe improve it more and push it Monday.
7 إعجابات
jomaxro
(Joshua Rosenfeld)
10 ديسمبر 2018، 3:12م
5
Looking good to me, thanks @j.jaffeux . All set here @bartv ?
إعجابَين (2)
bartv
(Bart )
10 ديسمبر 2018، 8:27م
6
Yep, it works fine for me too. Thanks for the quick solution everyone!
3 إعجابات