الفئات الفرعية تظهر فقط بعد التحديث وبعض المشاكل الأخرى

[md-misko]

Thanks for the new version, which brings better integration with Category Icons. There are some issues though:

1. If icon color is set in the Category Icons TC and the banner color in Category Banners is set to the same color, the icon in the banner title becomes ‘invisible’
2. New flex CSS style on the icon breaks long category names with icons on narrow viewports (mobile view)
   
3. Category with subcategories doesn’t show banner on landing, shows banner after refresh

First one can be easily fixed with CSS

h1 span.category-icon {
  color: rgb(255, 255, 255) !important;
}

but it would be even better if this could be overriden directly in the TC. Maybe a new setting set category icon color which would be enabled when show category icon is checked.

Second one is trickier, I’ve tried overriding it with CSS without consistent results, perhaps this will need a redesign on the structural level (I believe the icon element was previously in a separate div, but is now included inside h1)?

[awesomerobot (Kris)]

Great feedback, thanks! I’ve just merged an update to how the icon is aligned and added a setting that will override the category icon color when it’s enabled. This also requires an update to the category icons component (I needed to add a class name to adjust the layout), so make sure to update that as well.

[md-misko]

Thanks Kris, this works perfectly now.

I’m still having issues with

@md-misko

Category with subcategories doesn’t show banner on landing, shows banner after refresh

though, any ideas?

Checked on two different browsers on Android, same result.

[awesomerobot (Kris)]

oh I overlooked that one… this happens when directly visiting a subcategory?

[md-misko]

No, this only happens when directly visiting a category which has subcategories.

Edit: this only happens when opening such category directly from /categories view. When using a category drop down to select a category the banner is displayed correctly.

Directly visiting subcategories works fine.

[awesomerobot (Kris)]

@md-misko

this only happens when opening such category directly from /categories view. When using a category drop down to select a category the banner is displayed correctly.

Hmm, I’m not able to reproduce this…

Which desktop category page style are you using in your site settings? maybe I’m missing some specific situation

[Lilly (Lillian Louis)]

i installed this and have reproduced the error. in a category with a subcategory, i have clicked on the header breadcrumb and when you go to the category the header box is there but not the category banner.

[Lilly (Lillian Louis)]

awesome component btw. i will see if i can screengrab the missing category banner thing…

[Lilly (Lillian Louis)]

ok there are two ways the banner doesn’t show up - from category page (i am running topic author component). it works for sub-categories but not categories. it also happens from the topic header breadcrumb in a topic.

[md-misko]

@awesomerobot

some specific situation

I think I found the cause: in the top category settings set Default List Filter from all topics to no subcategories and refresh, then you’ll be able to reproduce.

@Lilly do you have the same no subcategories set by any chance?

[Lilly (Lillian Louis)]

i have this:

[awesomerobot (Kris)]

Oh yes, I can reproduce this now thanks for figuring that out. I’ll look into what’s going wrong with this.

[awesomerobot (Kris)]

@md-misko @Lilly, this was due to an inconsistency in Discourse, and this was fixed here at the end of the last week: DEV: Change the params for categoryNone redirect by CvX · Pull Request #20944 · discourse/discourse · GitHub

So this issue should go away the next time Discourse is updated.

[Lilly (Lillian Louis)]

thank you for all your ‘awesome’ work