Supporting tiktok urls for onebox

sam · March 3, 2021, 12:36am

But how do we avoid everything bouncing? We need the iframes to have a fixed height.

codinghorror · March 3, 2021, 1:32am

Yeah it has to be fixed height, that’s not negotiable. Fixed height is the starting point.

Falco · March 3, 2021, 1:39am

Onebox hits their oEmbed API and grabs the width and height and creates an iframe of fixed width/height respecting the TikTok video aspect ratio.

How that sounds @sam / @codinghorror ?

Richie · March 27, 2022, 4:10pm

Did this one ever make it to a roadmap?

sam · March 29, 2022, 7:23am

I think forcing height and width for the iframe is reasonable. Though I have general concerns around all iframe oneboxes.

Now that we have integrated onebox we should probably list exhaustively all the IFRAMEs we are allowing out of the box in a setting, so we call this out.

I kind of feel like allowed onebox iframes should not be * out of the box, instead it should call out all the iframes we are allowing.

david · March 29, 2022, 10:09am

We have this data - it’s available in the site setting dropdown. OneBox engines are not allowed to render iframes unless they add the origin to the list first:

They add to the list via the requires_iframe_origins directive:

github.com

discourse/discourse/blob/b2a8dc4c0fb80a6ef7721b310f2c59eebb218670/lib/onebox/engine/facebook_media_onebox.rb#L11


      
          # frozen_string_literal: true
          
          module Onebox
            module Engine
              class FacebookMediaOnebox
                include Engine
                include StandardEmbed
          
                matches_regexp(/^https?:\/\/.*\.facebook\.com\/(\w+)\/(videos|\?).*/)
                always_https
                requires_iframe_origins "https://www.facebook.com"
          
                def to_html
                  metadata = get_twitter
                  if metadata.present? && metadata[:card] == "player" && metadata[:player].present?
                    <<-HTML
                      <iframe
                        src="#{metadata[:player]}"
                        width="#{metadata[:player_width]}"
                        height="#{metadata[:player_height]}"
                        scrolling="no"

If the associated origin is not enabled, then the Engine is automatically disabled.

We could do that… but it would mean that new oneboxes will not automatically be added to the list.

Were you thinking of adding all the existing options? Or just a subset of the most common?

sam · March 31, 2022, 2:07am

Yeah I see, I forgot to expand the * , I don’t think we need to do anything extra here barring @Falco’s original suggestion (use oembed api to get height add iframe to page) then users can opt out if they want.

Going to put a pr-welcome on this in case the community want to give this a shot.

danielabc · November 19, 2022, 12:27pm

wow, how you do it? how did you embed it?

UnitedFreedom · January 4, 2023, 1:15am

Just wondering if there has been any progression with TikTok URL’s so when they react the same way as a YouTube video.

Thanks!

nat · July 17, 2024, 12:00am

This topic was automatically closed after 20 hours. New replies are no longer allowed.

Topic		Replies	Views
Videos not embedding Support	7	1284	November 8, 2023
Onebox Twitter embedding Feature	45	9807	October 5, 2020
Youtube Onebox revisited Feature	13	2565	December 3, 2014
Youtube "short" videos type embedding/oneboxing not working Feature completed	22	3377	December 10, 2022
How to embed tiktok, reels and spotify? Support	3	1030	December 27, 2022

Supporting tiktok urls for onebox

Related topics