L'expérience de Tecnoblog avec les commentaires Discourse

Falco · Mai 6, 2026, 3:08

Nous travaillons à améliorer ce flux

github.com/discourse/discourse

FEATURE: Add in-iframe sign-in flow for full app embed mode (#39756)

main ← embed-full-app-signin-flow

drafted 04:08PM - 05 May 26 UTC

xfalcox

+677 -4

Previously, full app embeds loaded on a third-party domain could not see the for…um's session cookie, leaving users effectively logged out, and `showLogin` only opened a dead-end `/login` tab the iframe never reacted to. This change adds an opt-in `embed_full_app_signin_flow` site setting that intercepts logged-out actions inside the iframe with a guided flow: an in-iframe modal opens a top-level sign-in tab that auto-closes via `postMessage` on success, and the iframe reloads to pick up the session cookie. On Safari, the flow first calls `requestStorageAccess()` to bypass ITP before opening the popup. ## Flow 1. User clicks an auth-gated action (Like, Reply CTA, etc.). `showLogin` / `showCreateAccount` (and the embed-topic-footer reply CTA) route into the new `embed-auth-flow` service. 2. **Safari only**: if `hasStorageAccess()` is false, an in-iframe modal asks the user to share their session. Confirming calls `requestStorageAccess()` (synchronously inside the click handler so user activation is preserved), persists the original intent, and reloads the iframe. 3. A sign-in modal opens a top-level `/login?embed_signin_callback=1` (or `/signup`) tab. A new `embed-signin-popup-callback` initializer detects a successful sign-in in that tab, posts a message to the opener, and closes the tab. 4. The iframe reloads on the explicit `postMessage` success signal so the user picks up their session. Plain popup close (user dismissed) tears down silently — no false "signed in" state. ## Setting - `embed_full_app_signin_flow` (boolean, default `false`, in the `embedding` area). Off by default; the existing Safari-only on-load storage access prompt and the legacy `window.open("/login")` paths continue to run when the flag is off. - Activating this requires the embed to be **same-site** to the host page (e.g. `forum.discourse.org` ↔ `meta.discourse.org`) **or** `same_site_cookies = "None"` for cross-site embeds. The browser's SameSite policy still applies to cookies after `requestStorageAccess()`, so cross-site Lax/Strict cookies cannot be delivered to the iframe. ## Implementation notes - **User activation preserved.** The modal is rendered via `service:modal` with native `<button {{on "click" handler}}>` elements rather than `service:dialog` (which wraps actions in `next()` and breaks user activation), so `requestStorageAccess()` and `window.open()` see a live activation token. - **Intent persisted across reload.** Sign-up vs. sign-in intent survives the storage-access reload via `sessionStorage`. - **API-unsupported fallback.** On Safari without `document.requestStorageAccess`, the service opens a plain top-level login tab (no callback) instead of trapping the user in a popup that cannot bridge cookies. - **Storage access denial is a dead-end on purpose.** The catch handler does not chain to a sign-in popup, since a sign-in tab cannot help an iframe that lacks storage access. The user retries the action to be re-prompted. ## Tests `tests/unit/services/embed-auth-flow-test.js` covers the state machine: gating, the Safari/non-Safari split for Storage Access, post-reload handling (including signup-intent preservation), denial behaviour, popup URL routing, and the API-unsupported fallback.

C’est un changement complexe, mais nous espérons pouvoir offrir une meilleure expérience utilisateur.

Sujet		Réponses	Vues
Embed Discourse comments on another website via Javascript Integrations embedding , how-to	123	302223	Octobre 27, 2025
How to automatically adjust iframe height for embedded wordpress posts WordPress	18	4939	Juin 26, 2025
Embed Discourse comments with on-page commenting? Feature	32	7999	Janvier 19, 2019
Discourse Comments stuck on "Loading..." Support	22	2111	Septembre 18, 2024
Embed Discourse as a full comment system on your site Announcements embedding	23	1244	Mai 6, 2026

L'expérience de Tecnoblog avec les commentaires Discourse

Sujets connexes