Forwarding an email may be odd for github, but not odd at all for our community using discourse. Sometimes people just want to forward an email with a few lines at the top to discuss it.
I’d rather have it go through (perhaps munging email addresses) and then clean it up later rather than having it just truncated silently, leaving everybody wondering what’s going on.
@techAPJ I will send you some sample forwarded emails. The test suite snippet you shared is interesting. Can you confirm that in that snippet, on line 83…
assert_equal "--\nHey there, this is my signature\n", reply.fragments.to_s
… that this means that it assumes that everything after two dashes at the start of a line is the signature and therefore should be truncated? This is what I think is causing problems for people on my discourse especially with forwarded emails.