Theme components are not overriding theme CSS any more?

Dev
1

Somehow the behavior has changed in how Discourse handles CSS in theme components. EDIT I did not understand what I was doing. I’m leaving this topic (in Dev instead of Bug) for future reference.

Very minimal example:

On Discourse 3.4.2 and tests-passed as of this morning (but this was also happening yesterday on 3.4.1)

Main theme #1: red border around navigation container

image
image463×250 9.59 KB

Theme component #2: blue border around navigation container

image
image564×250 9.88 KB

Theme component #2 is assigned to theme #1

image
image614×179 4.5 KB

Expected

Blue border around navigation container

Reality

Red border around navigation container

image
image1129×328 33.4 KB

1 Like
2

TLDR I am a fool.

Stylesheets are sorted like this

          if stylesheets.size > 1
            stylesheets =
              stylesheets.sort_by do |s|
                [s[:remote] ? 0 : 1, s[:theme_id] == @theme_id ? 1 : 0, s[:theme_name]]
              end
          end

When I tried to reproduce, I only used local stylesheets.

Reality is that stylesheets are loaded in this order:

  • remote stylesheets
    • theme components, alphabetically
    • main theme
  • local stylesheets
    • theme components, alphabetically
    • main theme
7 Likes