There is a problem with MessageFormat and languages with a country code like pl_PL and zh_CN

[Moin]

Continuing the discussion from Message Format support for localization:

@Discourse

Important: You need to modify the plural forms of your translation if your language uses forms other than “one” and “other”. You can add or remove forms within a { FOO, plural, ... } block in order to make it work for your languages

I ran into issues testing my text with MessageFormat in different languages, because it didn’t work in Polish.

But after looking at an existing text, I think the error isn’t on my end, but rather that something isn’t working as expected.

The example I looked at is in the invite modal: js.user.invited.invite.link_validity_MF

In English, everything is fine:

config/locales/client.en.yml

It also works in German:

config/locales/client.de.yml

But it doesn’t work in Polish:

config/locales/client.pl_PL.yml

And it doesn’t work in Chinese:

config/locales/client.zh_CN.yml

Based on the documentation topic, I would expect all these translations to work, not only the German translation. So, I assume there is a bug somewhere that affects languages that have a different number of plurals than English.

[small-lovely-cat]

Yes, the same problem, using zh-CN.

All the language string with MF end are broken and displayed in en-US format.

[david (David Taylor)]

Thanks for reporting! Do you think this might’ve been caused by a recent change? Or has it always been like this?

[Moin]

I don’t know. German works fine, so I usually don’t see that something is broken. I only noticed because I used messageFormat for the first time yesterday and chose Polish for testing. The rewind chat section is hidden if there are not enough messages, so to test more than the “other” part, I wanted a language with multiple plurals.

I just tried a dev install based on the stable branch, and it seems to work there:

[david (David Taylor)]

I think this should fix it:

FIX: Dasherize locale correctly for messageformat setup

Polish:

[Moin]

So I had really bad luck by choosing Polish as a language with a country code while I was testing, and if I had used Ukrainian everything would have worked without issues That would have saved me a lot of time.