Inconsistency in plural definition

Moin · July 21, 2024, 3:39pm

Continuing the discussion from Issue with pluralized (count) translation override:

I think Hungarian is not the only language affected by this. After checking Hebrew because of this Contribute > Bug mentioning problems, I thought maybe even more languages are affected, so I started looking for more cases.

github.com/eemeli/make-plural

packages/plurals/cardinals.js

main


      
          const a = (n) => n == 1 ? 'one' : 'other';
          const b = (n) => (n == 0 || n == 1) ? 'one' : 'other';
          const c = (n) => n >= 0 && n <= 1 ? 'one' : 'other';
          const d = (n) => {
            const s = String(n).split('.'), v0 = !s[1];
            return n == 1 && v0 ? 'one' : 'other';
          };
          const e = (n) => 'other';
          const f = (n, c) => {
            const s = String(n).split('.'), i = s[0], v0 = !s[1], i1000000 = i.slice(-6);
            return n == 1 && v0 ? 'one'
              : !c && i != 0 && i1000000 == 0 && v0 || c > 5 ? 'many'
              : 'other';
          };
          const g = (n) => n == 1 ? 'one'
              : n == 2 ? 'two'
              : 'other';
          
          export const af = a;
          export const ak = b;

This file has been truncated. show original

github.com/discourse/discourse

config/locales/client.tr_TR.yml

main


      
            separator: "."
            delimiter: ","
          human:
            storage_units:
              format: "%n %u"

After finding another one, I expect that even more languages are affected.

david · July 22, 2024, 12:10pm

Thanks @Moin!

I’ve made this change to stop the bleeding. This will limit the impact of failed compilations so that they only affect _MF strings, rather than taking down the whole site.

We’ll keep digging into the root cause, and update here when we have a solution.

loic · July 25, 2024, 12:32pm

We’ve just merged a patch that relaxes the MessageFormat compiler, allowing invalid plural keys in the messages:
https://github.com/discourse/discourse/pull/28062

This should take care of most of the problems. Other patches should follow soon.

loic · July 26, 2024, 10:27am

Another patch has just been merged:
https://github.com/discourse/discourse/pull/28083

This will prevent creating invalid MF overrides in the admin UI.

loic · July 29, 2024, 1:46pm

Just merged this PR:
https://github.com/discourse/discourse/pull/28097

Pluralization rules in Ruby should now be up-to-date with the ones we have in JS

j.jaffeux · August 3, 2024, 1:46pm

This topic was automatically closed 5 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Issue with pluralized (count) translation override Bug translation , fixed	9	437	July 22, 2024
Bad MF translation string in hebrew client locale causes fatal site error Bug	36	758	July 22, 2024
Overridden translation sticking after being pluralized Bug translation	3	408	August 2, 2024
Error message I don't find : "Error: No 'other' form found in pluralFormatPattern 0" Support	13	1139	April 24, 2020
Can't override pluralized string if it is missing in the locale file Bug translation	5	1129	May 13, 2019

Inconsistency in plural definition

AI-generated summary

Related topics