Pollice in su, due volte

nat · 28 Ottobre 2022, 11:36am

Correggi qui. Dovrebbe essere presto!

github.com/discourse/discourse

FIX: Evaluate all callbacks rather than override them

main ← multiple-post-menu-button-callbacks

opened 11:32AM - 28 Oct 22 UTC

nattsw

+30 -23

When we have multiple plugins triggering ``` api.removePostMenuButton("like"…, () => x); ``` the last plugin that makes the call gets to decide if the post menu button is removed or not. This change makes it such that we will evaluate all callbacks rather than just rely on the last one. Essentially, we ended up with duplicate like buttons when the discourse-upvotes plugin evaluates after discourse-reactions. <img width="354" alt="Screenshot 2022-10-28 at 7 33 19 PM" src="https://user-images.githubusercontent.com/1555215/198577684-add9e90d-7523-4595-8680-216add1cfe84.png"> Related: https://meta.discourse.org/t/thumbs-up-twice/240867/

Argomento		Risposte	Visualizzazioni
Changes to which reactions :thumbsup: are counted as likes :heart: Announcements reactions	46	3204	Maggio 27, 2024
Notice: testing Discourse Reactions here on meta for 1 week! Feature	85	8769	Aprile 14, 2021
Discourse Reactions Plugin official , reactions , included-in-core	66	42333	Ottobre 5, 2026
Thumbs-up - three names, one emoji UX reactions	12	1625	Settembre 11, 2023
Post Voting has likes enabled but they won't appear Bug reactions , post-voting	9	1314	Agosto 10, 2023

Pollice in su, due volte

Argomenti correlati