Top topics text missing

darkpixlz · August 13, 2024, 12:06am

Brave Linux, Meta theme. Unsure if this is intentional but it doesn’t look right

bryce · August 13, 2024, 12:53am

Hmm, I’m seeing the same thing on the default theme.

There’s an element for the name, but it’s empty!

This doesn’t seem intentional to me, some I’m going to move it to bug for now.

Arkshine · August 13, 2024, 2:44am

Here is a quick look to help figure out the issue before bed.

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/helpers/category-link.js#L159


      
            data-drop-close="true"
            class="${classNames}"
            ${
              opts.previewColor
                ? `style="--category-badge-color: #${category.color}"`
                : ""
            }
            ${descriptionText ? 'title="' + descriptionText + '" ' : ""}
          >`;
          
          let categoryName = escapeExpression(get(category, "displayName"));
          
          if (siteSettings.support_mixed_text_direction) {
            categoryDir = 'dir="auto"';
          }
          
          if (restricted) {
            html += iconHTML("lock");
          }
          _extraIconRenderers.forEach((renderer) => {
            const iconName = renderer(category);

displayName doesn’t exist. There is a name field instead.

The changes happen in this commit:

github.com/discourse/discourse

DEV: allows to alter category name/description (#28263)

committed 03:33PM - 08 Aug 24 UTC

jjaffeux

+104 -30

This commit adds two new getters to the category model: - `displayName` - `des…criptionText` These getters are used instead of `name` and `description_text` where appropriate. On top of this two transformers have been added to allow plugins to alter these getters: ```javascript api.registerValueTransformer( "category-display-name", ({ value, context }) => value + "-" + context.category.id + "-transformed" ); ``` ```javascript api.registerValueTransformer( "category-description-text", ({ value, context }) => value + "-" + context.category.id + "-transformed" ); ```

It seems to miss the getters in the context of user summary since the data is retrieved from /summary.json.

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/models/user.js#L1068-L1073


      
          if (summary.top_categories) {
            summary.top_categories.forEach((c) => {
              if (c.parent_category_id) {
                c.parentCategory = Category.findById(c.parent_category_id);
              }
            });

Maybe mapping top_categories with Category.create() or a basic specific class would be okay.

Moin · August 13, 2024, 5:20am

This makes me think of Category names missing on group permissions page. Both lost the text, so maybe it’s the same issue.

darkpixlz · August 13, 2024, 5:30am

Seems like it could possible be a result of then same issue but it’s in a different area. Not going to pretend like I know how Discourse works so I can’t input on that really

awesomerobot · August 13, 2024, 8:16pm

@joffreyjaffeux this and Category names missing on group permissions page look like regressions from DEV: allows to alter category name/description (#28263) · discourse/discourse@c197daa · GitHub

categoryName is returning an empty string, looks like these couple of places aren’t working with the new displayName getter?

joffreyjaffeux · August 13, 2024, 10:05pm

That should fix it:

github.com/discourse/discourse

FIX: access correct name and description

discourse:main ← jjaffeux:name-description

opened 09:37PM - 13 Aug 24 UTC

jjaffeux

+37 -2

`defaultCategoryLinkRenderer` is using a fake category object which doesn’t have… access to the functions and getters of category model. This had been incorrectly set in https://github.com/discourse/discourse/commit/c197daa04c3114184cbd3ec2f1cfade1b5701793 As we don't get a real category object, we have to call the transformers manually and also pass the fake category object as context, this is not ideal as people might try to access properties in the transformer which are not available on the category object given they will be different based on the context. Hopefully one day this helper and all the chain can be refactored to use a real category model. This commit also adds tests for these two properties in the category-link helper.

joffreyjaffeux · August 16, 2024, 10:05pm

This topic was automatically closed 3 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Bug on topic interface after an update \|\| Resolved Support	9	903	August 5, 2021
Categories not displayed in reseed modal Bug	2	56	November 6, 2024
Text missing in Discourse Docs top menu button Bug docs	4	505	June 28, 2022
Thumbnails missing when using the Minima theme Support topic-list-thumbnails	10	286	October 14, 2023
Experimental ‘lazy_loaded_categories’ feature enabled on Meta Feature feedback , experimental , lazy-load-categories	26	3098	October 1, 2024

Top topics text missing

Related topics