L'en-tête du sujet reste en bas de l'écran après avoir utilisé le navigateur mobile

awesomerobot · Septembre 3, 2024, 6:05

I have a fix incoming:

github.com/discourse/discourse

FIX: don't use post ID as timeline collapse delay

discourse:main ← discourse:fix-collapse-delay

opened 05:34PM - 03 Sep 24 UTC

awesomerobot

+2 -2

Reported here: https://meta.discourse.org/t/timeline-bug-on-mobile-video-attache…d/323633 This regards the expanded timeline on mobile. When the timeline is dragged and the post changes, the timeline doesn't fully auto-close ![image](https://github.com/user-attachments/assets/30d1077b-33de-4f60-ab62-523543949b93) What seems to happen, is that the postId is passed in from the topic controller like this: `this.appEvents.trigger("topic:jump-to-post", postId);` and in topic-navigation, the id is mistakenly used as the delay... so in cases like Meta where post ids are high the delay is very long (20+ minutes) and the expanded timeline appears stuck open this avoids the issue by setting up a separate postId param

The post id was accidentally being used as a delay, so it was technically still working… but very slowly

Sujet		Réponses	Vues
Post excerpts are missing from the expanded mobile timeline Bug	7	875	Janvier 20, 2020
Timeline bug on mobile (video attached) Bug topic-timeline	4	61	Septembre 3, 2024
Mobile progress-bar slide-up sometimes gets stuck Bug	10	1997	Avril 8, 2017
Topic summary on mobile doesn't close properly Bug	5	185	Septembre 3, 2024
Mobile timeline is broken on Android Chrome? Bug	5	1585	Février 27, 2017

L'en-tête du sujet reste en bas de l'écran après avoir utilisé le navigateur mobile

Sujets connexes