I’ve got two plugins that are failing travis tests. It appears that I don’t have any es6 files in them and eslint feels left out? Running linters/prettyfiers eslint yarn run v1.22.5 $ /var/www/discourse/node_modules/.bin/eslint -v v6.8.0 Done in 0.32s. prettier yarn run v1.22.5 $ /var/www/discourse…

Yes, eslint doesn’t like having nothing to do. This makes it feel more useful. mkdir -p assets/javascripts/discourse touch assets/javascripts/discourse/eslint.js.es6 git add assets/javascripts/discourse/eslint.js.es6 git commit -m 'try to make eslint not feel left out' git push Oh, but I think thi…

Ah, but how are you going to PR that without eslint complaining? :wink:

I understand so little of what’s going on here that I almost didn’t get your joke!

Yes I pushed this fix for github actions the other day: https://github.com/discourse/discourse/commit/110f6ec6dd16b154ad796a7de124148321240e40 So basically new eslint doesn’t like when it doesn’t match anything. I also took the opportunity to simplify the commands, will apply the same to our rake …

That should fix it: https://github.com/discourse/discourse/commit/a60ba75ac29f748774a495dd60beb28291a2bcb9 Let me know how it goes :+1:

Travis CI Travis CI enables your team to test and ship your apps with confidence. Easily sync your projects with Travis CI and you'll be testing your code in minutes. 2 files inspected, no offenses detected [2020-09-10 18:43:13] bundle exec ruby script/i18n_…

Oh right yes it’s using discourse-plugin-ci stuff, if you read at the code you will see: script.sh master echo "travis_fold:start:starting_docker_container" [ -d './test' ] || export RUBY_ONLY=1 [ -d './spec' ] || export JS_ONLY=1 …

Тесты Travis падают из-за eslint

Разработка

j.jaffeux (Joffrey Jaffeux) 10.Сентябрь.2020 18:18:14 6

Это должно исправить проблему:

Дайте знать, как всё прошло

Тема		Ответов	Просм.
Trouble with eslint since recent change to plugin-skeleton because failed to run yarn install Development	0	489	29.11.2023
Trouble with eslint Development	7	2546	30.07.2024
Code linting and formatting with prettier Development	6	2579	24.07.2018
Linting consistency Development	9	241	02.12.2025
Linting configuration Development development	4	245	11.08.2024

Тесты Travis падают из-за eslint

Связанные темы