Unable to post email address

(Gerhard Schlager) #1

It’s not possible to post an email address anymore. The following produces an Error 500:

  • [foo@example.com](http://foo@example.com)
  • [email]bar@example.com[/email]

This seems to be related to PR 4138.

parsed.path seems to be nil for email addresses. Does it even make sense to parse URIs with a scheme other than http and https?

(Sam Saffron) #2

Nahh not that, its a regression in extract links

NoMethodError (undefined method `slice!' for nil:NilClass)

/var/www/discourse/app/models/topic_link.rb:129:in `block (2 levels) in extract_from'
/var/www/discourse/app/models/topic_link.rb:116:in `each'
/var/www/discourse/app/models/topic_link.rb:116:in `block in extract_from'
/var/www/discourse/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb:211:in `transaction'
/var/www/discourse/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.6/lib/active_record/transactions.rb:220:in `transaction'
/var/www/discourse/app/models/topic_link.rb:106:in `extract_from'
/var/www/discourse/lib/post_creator.rb:385:in `extract_links'

I think @eviltrout fixed some bugs there recently … not sure.

(Régis Hanol) #3

Actually, I might have introduced that bug. Having a look.

(Régis Hanol) #4

@gerhard was right after all :wink:

(Régis Hanol) #5