User summary stats text colour not matching theme

[david (David Taylor)]

Here on Meta, stats look fine in the default theme

but when using the dark theme only some of them change to white text:

[jomaxro (Joshua Rosenfeld)]

Potential side effect of this? Testing now.

Tag CSS with !important flag

I removed the !important from those extra-info-wrapper colors and it didn’t break anything that I could see. https://github.com/discourse/discourse/commit/3d3215889326a256e571dfc4754fcc3df5475811

Edit: Nope, not that.

[david (David Taylor)]

@jomaxro

Potential side effect of this?

My instance is running a commit before @neil made that change and I’m still seeing the issue, so I don’t think it’s related

[jomaxro (Joshua Rosenfeld)]

Ha! I was just editing my post, not related.

[zogstrip (Régis Hanol)]

What @awesomerobot is suggesting in this post would prevent this from happening

Cleaning up our color palette

Turns out someone has essentially already built what I was thinking of. This always assumes you want an acceptable level of contrast (by WCAG standards) — but should be adaptable to set different contrast levels for things like borders/inactive buttons, etc http://codepen.io/MadeByMike/pen/sDpxg

[codinghorror (Jeff Atwood)]

Can anyone with dark theme confirm this is fixed?

[david (David Taylor)]

It is not fixed

[david (David Taylor)]

What is quite possibly the most simple PR ever:

https://github.com/discourse/discourse/pull/4986

[dax (Daniela)]

This is fixed now.
Thanks @david!