Users Complaining About Losing Points

Victor_Bramante · December 21, 2024, 4:10pm

Hi, I’m trying to understand how it works.

Tried to set up 2 Leaderboards to calculate Nov 2024 and Dec 2024 winners. Put fixed dates for both (ie 11/01 to 11/30) and none works ok, because:

you are forced to use a default period even it is stated as optional

default period option set to "All Time"307×105 2.4 KB
if I choose Monthly, calculates points of the latest 30 days even with fixed dates
if I choose Always, sums all the points and also bypass those fixed dates

What I have to do to calculate points of Nov-2024? Users views that they’re losing points each day so they’re sending me messages complaining about it.

Also, would be cool to have an option to hide the selector in the public view of the leaderboard.

selase · December 30, 2024, 7:04pm

Leaving the default period as All Time should work just fine. All Time here is intended to be within the bounds of the leaderboard’s from/to dates, if set.

However, there appears to be a bug where filtering the leaderboard by certain periods produces incorrect results. The score_period_condition implementation doesn’t properly account for the leaderboard’s From/To dates and conflicts with the main leaderboard bounds check.

github.com

discourse/discourse-gamification/blob/03ea20da05572acdd2481e61bbbdd7bfe30706d3/lib/discourse_gamification/leaderboard_cached_view.rb#L267-L285


      
          def score_period_condtion(period)
            date =
              case period
              when "yearly"
                "CURRENT_DATE - INTERVAL '1 year'"
              when "monthly"
                "CURRENT_DATE - INTERVAL '1 month'"
              when "quarterly"
                "CURRENT_DATE - INTERVAL '3 month'"
              when "weekly"
                "CURRENT_DATE - INTERVAL '1 week'"
              when "daily"
                "CURRENT_DATE - INTERVAL '1 day'"
              else
                nil
              end
          
            date ? "AND gs.date >= #{date}" : ""
          end

github.com

discourse/discourse-gamification/blob/03ea20da05572acdd2481e61bbbdd7bfe30706d3/lib/discourse_gamification/leaderboard_cached_view.rb#L150-L178


      
          WHERE
            (
              -- Leaderboard with both "to/from" dates
              -- Only scores created between specified dates
              (
                lb.from_date IS NOT NULL
                AND lb.to_date IS NOT NULL
                AND gs.date BETWEEN lb.from_date AND lb.to_date
              )
              OR
              -- Leaderboard without "from/to" dates. All scores
              (lb.from_date IS NULL AND lb.to_date IS NULL)
              OR
              -- Leaderboard with just "from" date
              -- Only scores created starting from the specified date
              (
                lb.from_date IS NOT NULL
                AND lb.to_date IS NULL
                AND gs.date >= lb.from_date
              )

This file has been truncated. show original

I’m looking into this, a fix should be ready soon.

Victor_Bramante · December 30, 2024, 7:51pm

Thanks, let me know when you do it to check again.

Happy new year!

Victor_Bramante · January 13, 2025, 11:19pm

Hi!

Was the fix applied? Seems that my leaderboards of december are not showing consistent results.

selase · January 14, 2025, 11:30am

Apologies for the delay. The fix isn’t applied yet, but I have two pending PRs ready for review. Will update once they’re merged.

FIX: Redo period filtering to respect leaderboard date bounds by s3lase · Pull Request #178 · discourse/discourse-gamification · GitHub fixes the materialized view query.
FEATURE: Add option to lock leaderboard view to default period by s3lase · Pull Request #179 · discourse/discourse-gamification · GitHub adds an option to disable the time period selector.

selase · January 20, 2025, 12:41pm

Thank you for your patience. The changes have been merged and are now available for verification. Please let us know if you encounter any further issues or have any questions.

Topic		Replies	Views
Setting a leaderboard date range should lock the default period Feature gamification	3	435	September 11, 2024
Allow to view scoreboard by 'Today' or 'Week' Support gamification	3	217	May 26, 2023
Gamification leaderboard pagination doesn't respect the selected date period Bug gamification	2	529	January 4, 2023
How to adjust gamification points without retroactively updating point values for old score-able actions Administrators gamification	0	258	May 17, 2024
Gamification From / To Date Range not saving when visible to groups option set Bug gamification	4	436	July 11, 2022

Users Complaining About Losing Points

Related topics