Using @ breaks adding groups to message

[robmc (Robert McIntosh)]

When adding users to a new message, using the @ symbol searches only usernames, not groups.

Is this intentional? Looking back at previous instructions, it seems that we were encouraged to use the @

@sam

The composer was extended to allow you to use a group name as target for a message (provided the group allow messaging)

When trying to send a message to a group, where Everyone is allowed to mention and message the group, you are unable to add them. It appears that if you start with the @ symbol the autocomplete only accepts usernames, even if you add the full name of the group.

If you just enter text however, then the group names do appear

[sam (Sam Saffron)]

@robmc

When adding users to a new message, using the @ symbol searches only usernames, not groups.

To me this looks like a regression, @joffreyjaffeux do you recall anything here?

[joffreyjaffeux]

No, it’s not select-kit. And I don’t think I ever touched this.

[sam (Sam Saffron)]

@nbianca I recall you worked on this selector in the past can you have a look at this issue?

[nbianca (Bianca)]

I tried to bisect this, but I had no luck… because this has been broken before v1.8! (I could not install older versions because I had problems with dependencies that were not worth the time)

Anyway, I got it fixed. The problem is that the query that gets to the server includes @ which seemed to work fine for usernames (Search.ts_query is pretty smart), but did not for groups.

Fixed by

https://github.com/discourse/discourse/pull/6506

[zogstrip (Régis Hanol)]

@nbianca

The problem is that the query that gets to the server includes @ which seemed to work fine for usernames ( Search.ts_query is pretty smart), but did not for groups.

Since they both use the same namespace, should they also use the same code path for search (on the server)?

[nbianca (Bianca)]

Currently there is search data for users, topic, posts, categories and tags, but none for groups. Implementing it is definitely possible, but I do not think it is worth the effort.

[zogstrip (Régis Hanol)]

I see, we should at the very least do the same stripping on the server for those who call the API directly.

And maybe give some (ts_query) to Group.search_groups as well

[nbianca (Bianca)]

@zogstrip

I see, we should at the very least do the same stripping on the server for those who call the API directly.

At first I implemented the stripping on the server side, but then I realised it isn’t server’s fault. If the client wants correct results, they should ask the correct questions.