Very large gifs should be shown as previews

Feature
21

Yes @techapj can you add support for gfycat to oneboxer?

4 Likes
22

I had added it to onebox. It looks like for some reason just white listing it like imgur didn’t worked as expected.

Definitely the first step is onebox embedding gfycat.

The next step I think would be for a plugin to do the gif -> gfycat conversion. Anyone could do this, and if gfycat support is properly added to onebox, I would do it eventually if no one else did.

5 Likes
23

I suspect it didn’t get properly whitelisted in the HTML sanitizer.

1 Like
24

It seems like there is a bug with gfycat oEmbed, it always returns CooperativeScentedAnkolewatusi in the iframe.

Various links that confirms the issue:

Removing gfycat from whitelist, until this issue is resolved.

4 Likes
25

The OpenGraph data seems to be correct, can’t that be used instead of oEmbed?

2 Likes
26

Okay, added custom gfycat handler to use OpenGraph data endpoints instead of oEmbed:

https://github.com/discourse/onebox/pull/285

4 Likes
27

Does this do the gif like embed, or does it require pressing play?

1 Like
28

It requires pressing play. Demo pic:

1 Like
29

This is because if gifs without sound autoplay, then gifs with sound (could) autoplay too


30

gyphy gifs don’t have sound because they are converted from gifs.

The whole point is not to embed a video, but to use video like a gif.

That means the gif should loop (yes I know not all gifs loop) and auto play. At the very least, it should loop until the user presses stop.

1 Like
31

I understand @riking’s concern, but in this case it is totally safe to whitelist autoplay+loop for oneboxed Gifly GIF-videos as they do not have sound.

Note that Imgur also does not support sound, but as a precaution oneboxed GIF-videos are muted by default:

<video id="video" autoplay="autoplay" muted="muted" preload="auto" loop="loop" poster="//i.imgur.com/YfPjduYh.jpg">
    (...)
</video>

We should simply do the same for Gfycat.

4 Likes
32

Doesn’t look like this is working? :frowning:

33

The gem needs to be updated.

@zogstrip can you please bump onebox version and update the gem?

1 Like
34

There you go :wink:

https://github.com/discourse/discourse/commit/f180d2202564febf8c6195684c01b6c7f51d4faa

7 Likes
35

@techAPJ I rebuilt @chapel’s post and it seems that it isn’t looped by default?

2 Likes
36

I believe this is now handled with @vinothkannans recent PR.

http://img0.joyreactor.cc/pics/post/%D0%B3%D0%B8%D1%84%D0%BA%D0%B8-superjail-%D0%BC%D1%83%D0%BB%D1%8C%D1%82%D1%81%D0%B5%D1%80%D0%B8%D0%B0%D0%BB-%D0%A1%D0%B2%D0%BE%D1%8F-%D0%B0%D1%82%D0%BC%D0%BE%D1%81%D1%84%D0%B5%D1%80%D0%B0-1886210.gif(image larger than 4096KB)

The xxxxtra large Gif was (eventually, pending background tasks) replaced with image placeholder. @vinothkannans does the tooltip work now so I can mouse over this kind of random looking generic image placeholder and get a plain English explanation of what happened?

3 Likes
37

Let’s see if this is still working:

https://media2.giphy.com/media/l1J9u3TZfpmeDLkD6/giphy.gif(image larger than 4096KB)

4 Likes