خلل غريب في discourse-assign

Firepup650 · 21 أغسطس 2023، 10:15م

We have this random topic on our forum that has somehow managed to become invisible. Deleting and restoring the topic via tha API has had no effect. It seems like discourse-assign causes it to fail to load, as it loads perfectly fine when plugin JS is disabled using safe mode.
You can find this buggy post here:

Here’s a stack trace for one of the errors we get when opening the topic:

Cannot read properties of undefined (reading 'includes')
at n.<anonymous> (https://amcforum.wiki/assets/plugins/discourse-assign-e7635afd56f3ebe38bb2866d6121e1e726de50fbfc472646a6e738a3d44b3930.js:208:1008)
at https://amcforum.wiki/assets/discourse-12f38708c935010f61959d1ee5b74a9770c91ed393b88e3a7a5fe0a3de467a89.js:9931:74
at Array.forEach (<anonymous>)
at n.buildClasses (https://amcforum.wiki/assets/discourse-12f38708c935010f61959d1ee5b74a9770c91ed393b88e3a7a5fe0a3de467a89.js:9931:51)
at n.draw (https://amcforum.wiki/assets/discourse-12f38708c935010f61959d1ee5b74a9770c91ed393b88e3a7a5fe0a3de467a89.js:10348:34)
at n.render (https://amcforum.wiki/assets/discourse-12f38708c935010f61959d1ee5b74a9770c91ed393b88e3a7a5fe0a3de467a89.js:10324:54)
at a (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:331:20)
at e.exports (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:333:34)
at e (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:337:6)
at Object.e [as render] (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:342:48)
at https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:976:62
at e.exports (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:977:40)
at u (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:952:8)
at Object.l [as patch] (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:949:3)
at e.exports (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:981:29)
at u (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:952:8)
at Object.l [as patch] (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:949:3)
at e (https://amcforum.wiki/assets/chunk.660.cfa44cc656d26c5d04fa-3aa2531cc98e968234ee473ed8fc2ef14895f4ba22e888d7d542e7d3620f8056.js:953:114)
at e.rerenderWidget (https://amcforum.wiki/assets/discourse-12f38708c935010f61959d1ee5b74a9770c91ed393b88e3a7a5fe0a3de467a89.js:1844:163)
at p.invoke (https://amcforum.wiki/assets/vendor-d19c5d3106737be843b2f1f98da81f661a0e985585b4a1fd14cab77cbfa60e37.js:4339:182)
at p.flush (https://amcforum.wiki/assets/vendor-d19c5d3106737be843b2f1f98da81f661a0e985585b4a1fd14cab77cbfa60e37.js:4331:141)
at h.flush (https://amcforum.wiki/assets/vendor-d19c5d3106737be843b2f1f98da81f661a0e985585b4a1fd14cab77cbfa60e37.js:4346:207)
at q._end (https://amcforum.wiki/assets/vendor-d19c5d3106737be843b2f1f98da81f661a0e985585b4a1fd14cab77cbfa60e37.js:4410:9)
at _boundAutorunEnd (https://amcforum.wiki/assets/vendor-d19c5d3106737be843b2f1f98da81f661a0e985585b4a1fd14cab77cbfa60e37.js:4358:595)

Lilly · 21 أغسطس 2023، 11:10م

yea the console is showing errors here.

github.com

discourse/discourse-assign/blob/0cbf10b8055370445bd36536e51986bf48bdc57e/assets/javascripts/discourse/initializers/extend-for-assigns.js#L482C1-L486C6


      
          api.addPostSmallActionClassesCallback((post) => {
            if (post.actionCode.includes("assigned") && !siteSettings.assigns_public) {
              return ["private-assign"];
            }
          });

sam · 21 أغسطس 2023، 11:38م

Its a small action with no action code!

You can fix this using the console, enter the container find the small actions on the topic, one of them is missing an action code.

We should probably add a sql validation to ensure this is impossible.

hello-smile6 · 21 أغسطس 2023، 11:39م

I think those can be created using the API (we have a theme component that creates one), will we have to manually run some kind of database migration?

hello-smile6 · 21 أغسطس 2023، 11:42م

Here’s an example of another one created using our theme component:

hello-smile6 · 21 أغسطس 2023، 11:48م

It seems like 25 different topics all have posts that are breaking discourse-assign, according to the results of this SQL query (using data explorer):

SELECT id topic_id FROM topics topic WHERE topic.id IN (SELECT topic_id FROM posts WHERE post_type = 3 AND action_code IS NULL)

sam · 21 أغسطس 2023، 11:48م

GPT bot to the rescue…

On another topic

Thank you for the additional information. Given the code snippet from the topic.rb file, it’s clear that small actions are indeed created as a type of post with post_type set to Post.types[:small_action] and an action_code associated with it.

If we want to find small actions with no action_code, we can adjust the query to look for posts where post_type is 3 (small action) and action_code is nil.

Here are the revised steps:

Enter the container: You can enter the container by using the command ./launcher enter app from the command line in your Discourse directory.

Run rails c: Once inside the container, you can start the Rails console by running the command rails c.

Find the Topic: To find the topic, you can use the Topic.find_by(id: your_topic_id) command. Replace your_topic_id with the ID of the topic you are looking for.

Find the Small Action with no action_code: Small actions are stored in the posts table with post_type set to 3 and action_code is nil. You can find the small action related to your topic with sa = Post.where(topic_id: your_topic_id, post_type: 3, action_code: nil).

Delete the Small Action: Once you have the small action, you can delete it by running sa.destroy_all.

Please make sure to replace your_topic_id with the actual ID of your topic. Also, be careful when deleting records, as it can’t be undone.

Let me know if you have any questions or need further assistance!

Firepup650 · 22 أغسطس 2023، 1:25ص

If that’s the check, why not just add !!post.actionCode to the if block?

Firepup650 · 12 سبتمبر 2023، 11:07ص

Finally got around to this, and PR’d a change:

الموضوع		الردود	مرات العرض
Cannot delete topic that is assigned Bug	2	846	4 أبريل 2018
Topic/Post is assigned (but not really) Bug assign	1	43	28 أكتوبر 2024
Discourse Assign Plugin official , assign , included-in-core	24	38702	29 يوليو 2025
Endless spinner on some posts Bug fixed	14	172	12 سبتمبر 2024
Visibility of assign action posts is controlled by whispers allowed groups Bug assign , whispers	3	54	16 سبتمبر 2024

خلل غريب في discourse-assign

الموضوعات ذات الصلة