Wrong tooltip on like button for non registered user

th21 · August 3, 2023, 10:20pm

If I was not logged in and hovering over the like button, the wrong tooltip shows up.

sam · August 4, 2023, 1:08am

Legit, we will have a look at getting it sorted.

Should say:

Please Sign up or Log In to like the post

ted · August 10, 2023, 4:00am

Thanks for the report, @th21!

This bug in discourse-reactions has been fixed here:

github.com/discourse/discourse-reactions

FIX: Display correct title text for unauthenticated users

discourse:main ← discourse:fix/unauthenticated-title-text

opened 03:34AM - 10 Aug 23 UTC

Drenmi

+7 -0

[Meta](https://meta.discourse.org/t/wrong-tooltip-on-like-button-for-non-registe…red-user/273896). ### What was the issue? Unauthenticated users would incorrectly see this title text when hovering the reaction button: <img width="247" alt="Screenshot 2023-08-10 at 11 33 05 AM" src="https://github.com/discourse/discourse-reactions/assets/5259935/d300f7a9-aea2-4cb2-b5d1-8b2defe7c746"> ### How does this fix it? This change adds a new translation key and uses it when user is authenticated: <img width="270" alt="Screenshot 2023-08-10 at 11 32 43 AM" src="https://github.com/discourse/discourse-reactions/assets/5259935/0ab506cd-3b05-4ec9-a45e-2b8ac15d77e0"> ### Should there be a test for this? I am on the fence. Should QUnit/system tests go to the granularity of title texts? I'm happy to add it if there's a compelling case made. WDYT?

ted · August 10, 2023, 4:00am