For instance:
“This user has not started any topics yet” makes more sense as it is grammatically correct and, in this case, “you” refers to the user viewing the page, but they cannot act on the other’s behalf.
9 curtidas
andrei
(Andrei Prigorshnev)
Março 31, 2022, 4:09pm
3
This PR adds the message “%{username} has not started any topics yet” when looking at another user’s page:
discourse:main
← discourse:ux/cleaner-messages-for-empty-state-on-the-user-activity-topics-page
opened 06:34PM - 23 Mar 22 UTC
We were using blank page copy with the word “you”, even when viewing someone els… e’s profile:
<img width="500" alt="Screenshot 2022-03-23 at 19 25 11" src="https://user-images.githubusercontent.com/1274517/159770373-7dfc0e45-de8f-47c6-939f-0177c630adc7.png">
After this fix we'll be showing "{username} hasn't started any topics yet" instead.
I also fixed a confusing API that I introduced myself some time ago. In this PR I introduced the `isCurrentUser` function instead of `isAnotherUsersPage`. I didn't remove `isAnotherUsersPage` yet because there exists a usage of it on a plugin. I'll take care of it after merging this PR.
Also, here are fixes for the same problem on other pages:
4 curtidas
andrei
(Andrei Prigorshnev)
Fechado
Abril 4, 2022, 6:00am
4
This topic was automatically closed after 3 days. New replies are no longer allowed.