Found while building 2.2.0.beta10~git21.f7b7bc8abe files with x bit without a shebang line. bin/docker/README.md lib/javascripts/moment_locale/*.js script/import_scripts/json_generic.rb vendor/assets/javascripts/sweetalert.js probably just chmod -x all the files zero byte files app/assets/javascr…

What RPM package? Discourse isn’t distributed in RPM.

I build one myself. and our package check found those issues. Thought I would clarify them with upstream.

Does any of this need fixing for the release @j.jaffeux ?

None of the listed files should have the x bit set. As for the empty files, if there are indeed useful, then we should add a comment explaining why/where they’re used.

A few small issue found during RPM package build

Development

j.jaffeux (Joffrey Jaffeux) January 31, 2019, 10:01am 6

Yes I see no reasons to act on this before release. Im assigning this to me, to try to remove these files after release.

Topic		Replies	Views
Discourse build is broken due to removed file? Development	11	2124	October 16, 2017
Ubuntu development install: Permission denied @ apply2files Self-hosting	1	3203	July 15, 2019
Failed to bootstrap while rebuilding a contrainer Self-hosting	6	1375	October 10, 2016
Minor spelling issue in installation script Self-hosting	2	728	February 6, 2018
Mini_racer breaks build on latest-release Product Support unsupported-install	2	1469	April 29, 2019

A few small issue found during RPM package build

Related topics