A few small issue found during RPM package build

Development

AI-generated summary

A discussion is underway regarding issues found during an RPM package build of Discourse. darix reported two issues: files with execute permissions without a shebang line, and zero-byte files. darix clarified that they build their own RPM package and were seeking clarification from upstream. zogstrip confirmed that the listed files should not have execute permissions and suggested adding comments to explain the purpose of the empty files. joffreyjaffeux assigned the issue to themselves, planning to address it after the release, and codinghorror inquired about the need for immediate action.

1

Found while building 2.2.0.beta10~git21.f7b7bc8abe

files with x bit without a shebang line.

bin/docker/README.md
lib/javascripts/moment_locale/*.js
script/import_scripts/json_generic.rb
vendor/assets/javascripts/sweetalert.js

probably just chmod -x all the files

zero byte files

app/assets/javascripts/admin/templates/components/flag-counts.hbs
app/assets/javascripts/admin/templates/components/permalinks-list.hbs
app/assets/javascripts/discourse/templates/modal/merge-topic.hbs
app/assets/javascripts/discourse/templates/modal/split-topic.hbs
app/views/list/top.erb
app/views/static/password_reset.html.erb
app/views/static/signup.html.erb
public/javascripts/ace/mode-text.js
spec/fixtures/plugins/my_plugin/nested/plugin.rb

are all of them expected?

2

What RPM package? Discourse isn’t distributed in RPM.

3

I build one myself. and our package check found those issues. Thought I would clarify them with upstream.

4

Does any of this need fixing for the release @j.jaffeux?

5

None of the listed files should have the x bit set.

As for the empty files, if there are indeed useful, then we should add a comment explaining why/where they’re used.

6

Yes I see no reasons to act on this before release. Im assigning this to me, to try to remove these files after release.