Why run UpdatePostUploadsSecureStatus even when secure uploads is disabled?

martin · February 19, 2023, 11:38pm

Good question – this is called in two places. PostCreator:

lib/post_creator.rb

3c57db5c6


      
          def update_uploads_secure_status
            @post.update_uploads_secure_status(source: "post creator") if SiteSetting.secure_uploads?
          end

And PostRevisor:

github.com/discourse/discourse

lib/post_revisor.rb

3c57db5c6


      
          # This must be done before post_process_post, because that uses
          # post upload security status to cook URLs.
          @post.update_uploads_secure_status(source: "post revisor")

However as you can see I neglected to do the SiteSetting.secure_uploads? check in the latter…I will make a PR to fix this and just move the check to post.update_uploads_secure_status.

Edit: PR is here, hopefully should merge today FIX: Do not enqueue UpdatePostUploadsSecureStatus unnecessarily by martin-brennan · Pull Request #20366 · discourse/discourse · GitHub

Topic		Replies	Views
Minio: A header you provided implies S3 functionality that is not implemented Product Support	19	10613	April 5, 2021
Can not edit topics with picture with S3 backend Bug	10	1344	July 9, 2021
Secure Uploads Announcements secure-uploads	43	18799	July 24, 2025
Feature request: secure-uploads for S3 backends without per-object ACLs Feature s3 , secure-uploads	2	180	October 18, 2026
Upload objects to private S3 is not working Product Support s3	5	2973	June 14, 2022

Why run UpdatePostUploadsSecureStatus even when secure uploads is disabled?

Related topics