Poll Plugin Fix and Bumping the version

Contribute Feature

AI-generated summary

The discussion revolves around the Poll Plugin Fix and bumping its version. cdesch mentions a recent patch, but the version in plugin.rb was not bumped, which might prevent the plugin from being upgraded through the admin/upgrade panel. cdesch suggests merging a pull request to bump the version.

sam explains that the issue is not with the version, but rather that the poll plugin is bundled with Discourse, making it difficult to update independently. This is due to the plugin being included in the main repository, which makes it hard to try out beta releases.

codinghorror thinks it’s fine that core plugins come with Discourse and don’t require separate updates. However, sam believes that long-term, the poll plugin should be pulled out or integrated into Discourse like emojis.

cdesch argues that if plugins can’t be changed, disabled, or updated independently, they aren’t truly plugins. A possible solution could be to bundle these plugins by allowing them to be installed, enabled, or disabled through the admin panel, with default installations providing links to the plugins’ Git repositories.

1

The poll plugin recently had an issue which required users to login twice to vote. It was patched a day ago with this patch but the version in the plugin.rb was never bumped to 0.1 to 0.2 which I believe doesn’t allow the poll plugin to be upgrade through admin/upgrade panel (screenshot below). Is that correct? Will bumping the poll plugin version allow the upgrade without having to restart the entire docker container?

If thats true, please consider merging my pull request #3250 to bump the version to 0.2

Screen Shot 2015-03-04 at 2.24.01 PM.png749×457 16 KB

2

That is not the problem actually, this is a bit of a feature discussion.

As it stands the poll plugin is bundled, together with lazyYT discourse/plugins at main · discourse/discourse · GitHub

Prior to Docker days this was the only clean way to ensure adoption. These days we have a simpler story, but its hard to make a change cause we can not reach in to all the container definitions out there and include extra repos.

So for now you get latest poll by updating Discourse :frowning:

3개의 좋아요
3

I think that is fine personally. These are core plugins, they come with Discourse.

4

The pain point here is that its hard to try out “beta” releases, long term poll should probably be pulled out, or maybe just integrated in like we did with emoji.

1개의 좋아요
5

If they already come with discourse, are they really plugins? If I can’t change/disable/update plugins independently of discourse then they aren’t plugins in the true sense.

Maybe it would work better for bundling these particular plugins by allowing them to be installed/enabled/disabled through the admin panel. Instead of keeping the Poll Plugin and the lazyYT in the main discourse repository, the default installation could provide links to these plugins git repos through the admin panel.