Quoting across discourse instances with links getting process as local links

riking · 24 Aprile 2015, 2:48am

~~Potentially~~ Definitely related to the change I just made?

https://github.com/discourse/discourse/pull/3387/files#diff-5706007ce16fc2a1eb8526567e15dc0bR13

lib/onebox/engine/discourse_local_onebox.rb

3681674ec


      
          def self.===(other)
            if other.kind_of?(URI)
              uri = other
              begin
                route = Rails.application.routes.recognize_path(uri.path)
                case route[:controller]
                when 'topics'
                  true
                else
                  false
                end
              rescue ActionController::RoutingError
                false
              end
            else
              super
            end
          end

A fix might be to replace true with super - in that case, it’ll check for Discourse.base_url as well.

Or stick return false unless super at the start of the method.

Here’s a fix:

https://github.com/discourse/discourse/pull/3395

Argomento		Risposte	Visualizzazioni
Quote with links drops the link Bug	1	917	Luglio 14, 2017
WP Discourse showing wrong links to forum WordPress	6	1417	Dicembre 27, 2019
Links in quotes sometimes not working Bug	5	1819	Gennaio 29, 2015
Until a link is provided publicly it does not work Bug	4	865	Maggio 8, 2018
Removing title from URL breaks links Product Support	24	2862	Luglio 2, 2019

Quoting across discourse instances with links getting process as local links

Argomenti correlati