Positioning issues with RTL locales after recent updates

AI-generated summary

A user, inj3ct0r, reported issues with RTL locales after a recent update, including a crashed user card and a non-functional reply button. simon identified that the user card position handling for RTL locales had been removed, causing the issue. He suggested setting a right position for the user card when an RTL locale is used.

simon also reproduced the issues on Meta and found that the composer issue is related to the discourse-full-width-component. He suggested loading the site in safe mode to fix some of the problems, which inj3ct0r tried and reported that it fixed the reply button issue but not the user card issue.

simon continued to investigate the user card issue. Finally, Osama announced that the issue has been fixed via a commit: https://github.com/discourse/discourse/commit/eff6e4b405e3fb67126dfe5cf05a9fcaf90d5fab.

Hello, I hope you are well.

after last update today i got a crashed user card :frowning:

and it down with main container

2 Likes

There used to be special handling of the user card position for RTL locales: https://github.com/discourse/discourse/blob/4896a7dec79203cd44265bb2372c2b4a223c3d26/app/assets/javascripts/discourse/views/user-card.js.es6#L86-L120

With the updates to the user card, that seems to have been removed. The left position in the user card’s inline styles is wrong for RTL locales. From memory, I think the easiest way to deal with it is to set a right position for the user card when an RTL locale is used. The left and right properties can’t just be switched in the inline style rule though.

1 Like

Hello, New Update
the Reply button doesn’t work

2 Likes

It “works”, but the post editor isn’t usable.

These issues can be reproduced on Meta if you select an RTL locale for your interface language:

Edit: the issue I’m finding with the composer on Meta seems to be related to GitHub - discourse/discourse-full-width-component: Make Discourse occupy the full browser width · GitHub.

The issue with user cards can be reproduced on either Meta or try.discourse.org in safe mode.

Also, the user-tip modals are incorrectly positioned for RTL locales in safe mode:

2 Likes

it doesn’t work in my forum for me and for my members

1 Like

Can you try loading your site in safe mode to see if that fixes some of the problems? To do that, append the following onto the URL in your browser’s address bar:

?safe_mode=no_themes,no_plugins

For example https://try.discourse.org/t/what-do-the-avatars-in-the-topic-list-mean/65?safe_mode=no_themes,no_plugins

3 Likes

yes it fix the reply button but the user card still broken

1 Like

This is still an issue:

2 Likes

Hi @inj3ct0r

This has been fixed via this commit:

https://github.com/discourse/discourse/commit/eff6e4b405e3fb67126dfe5cf05a9fcaf90d5fab

2 Likes

This topic was automatically closed after 4 days. New replies are no longer allowed.