Inconsistency in plural definition

flink91 · July 25, 2024, 12:32pm

We’ve just merged a patch that relaxes the MessageFormat compiler, allowing invalid plural keys in the messages:

github.com/discourse/discourse

FIX: Allow invalid plural keys in MF translations

discourse:main ← discourse:loic-handle-bad-mf-pluralization-rules

opened 04:08PM - 24 Jul 24 UTC

Flink

+40 -8

We can get translations with invalid plural keys from Crowdin or from custom ove…rrides. Currently, this will raise an error and the locales won’t be outputted at all. This PR addresses this issue by using the new `strict: false` option of our `messageformat-wrapper` gem, allowing to generate locales even if there are invalid plural keys present.

This should take care of most of the problems. Other patches should follow soon.

Topic		Replies	Views
Issue with pluralized (count) translation override bug translation , fixed	10	104	July 22, 2024
Overridden translation sticking after being pluralized bug translation	4	287	August 2, 2024
Always use %{count} variable when translating pluralized strings translations	7	2817	May 20, 2019
Number pluralization 'one' category misused translations	1	1278	August 29, 2018
Locale fallback to English doesn't work for pluralized strings bug	4	1062	February 28, 2017

Inconsistency in plural definition

Related Topics