I’ve got a new plugin that’s failing lint tests: Run if test -f .prettierrc.cjs; then yarn run v1.22.22 $ /home/runner/work/discourse-multi-rating/discourse-multi-rating/node_modules/.bin/eslint --ext .js,.gjs,.js.es6 --no-error-on-unmatched-pattern test/javascripts assets/javascripts admin/assets/…

I’ve seen this error on my own plugin. I figured out it was because I tried to update the eslint config file from .eslintrc.cjs to the latest flat config format eslint.config.js via the eslint migration. eslint.config.js doesn’t support the --ext ( Command Line Interface Reference - ESLint - Pluggabl…

[image] Alteras: I figured out it was because I tried to update the eslint config file from .eslintrc.cjs to the latest flat config format eslint.config.js via the eslint migration. That’s what’s so strange. I don’t see a eslint.confi.js anywhere on my filesystem (if I’m to trust locate, and …

Oh that’s weird… Yes, I was able to get mine to work. I would check the package.json to see if the devDependencies has "eslint": "8.57.0", and not a 9.x.x

[image] Alteras: I would check the package.json Yes. :crying_cat_face: I just noticed that eslint and prettier were changed in package.json. I swear it was just a minute ago that I cloned it from the skeleton. :person_shrugging: Now it’s giving me (legit) errors at github, but I can’t get es…

Jay, do: yarn then yarn eslint --fix plugins/<my-plugin> (obviously update “my plugin”) both from discourse directory

OMG. I’d just managed to fix it in some way that was completely impossible to reproduce, so this is a lifesaver. And now I’ve added it to my magic file so this might work next time if [[ "$ARG" == 'fix-eslint' ]] then cd ~/src/discourse-repos/discourse yarn for x in ~/plugins/* do yarn…

Trouble with eslint

Development

pfaffman (Jay Pfaffman) July 30, 2024, 3:25pm 8

Wait. Are you saying that this will update eslint to the proper version? Or run eslint? Or that if I run it that way, it’ll be the right version?

Topic		Replies	Views
Trouble with eslint since recent change to plugin-skeleton because failed to run yarn install Development	0	501	November 29, 2023
Travis tests failing due to eslint Development	7	1212	September 10, 2020
Linting configuration Development development	4	333	August 11, 2024
Code linting and formatting with prettier Development	6	2670	July 24, 2018
Linting consistency Development	9	385	December 2, 2025

Trouble with eslint

Related topics