Существующие пользователи не добавляются в группы по приглашению, если у них уже есть доступ к теме, на которую ссылается приглашение

pento · 16.Май.2025 06:46:26

Спасибо за отчет об ошибке, @nathank!

Я только что объединил исправление для этого:

github.com/discourse/discourse

FIX: Allow existing users to accept invites that add them to a group. (#32762)

main ← pento/fix-invite-existing-user-to-group-with-redirect

merged 06:42AM - 16 May 25 UTC

pento

+48 -7

## ✨ What's This? This is a tweak to the change in #31301. That change all…owed existing users to be redirected to a topic that they already have access to by bypassing the invite acceptance step, and simply redirecting them there. Since some invites also add the invited user to one or more groups as well, this was causing the group adding step to be skipped in existing workflows. This change addresses the issue by checking to see if the user would be added to any groups before redirecting. To avoid introducing a CSRF issue, it works by forcing the user through the normal invite acceptance flow, ensure there's user interaction before being added to any groups. This change also tweaks the behaviour of #31301 to not follow redirects of expired invitations. ## 👑 Testing ### Basic functionality 1. Create a test user. 2. Create an invite that lands on a topic that the test user can access already. 3. Add a group to the invite (which the test user isn’t currently a member of). 4. Login as the test user. 5. Visit the invite link with that user. ### Variations 1. Add the test user to the group before they visit the link. 2. Add multiple groups to the invite, of which the test user is a member of some, or all.

Дайте знать, если это исправит проблему для вас или если вы столкнетесь с какими-либо другими проблемами!

Тема		Ответов	Просм.
Invitation Links are Only Working for Non-existing Users & Breaking Our Current Implementation Bug invites	5	224	24.03.2025
New invite link should work for existing users Feature invites	14	1545	24.11.2022
Issue with Invite Link: "Add to Group" Not Working When "Arrive at Topic" is Enabled Bug invites	1	95	02.04.2025
Inviting users with groups field failed when there is an existing user in the list Bug	8	877	22.04.2019
Sorry, that user has already been invited. You may only invite a user to a topic once Support	10	955	21.07.2018

Существующие пользователи не добавляются в группы по приглашению, если у них уже есть доступ к теме, на которую ссылается приглашение

Связанные темы