Currently running Discourse 3.5.0.beta5-dev ( eff31e0d42 ). Would anyone know if the API response from the /admin/users/list/all.json endpoint has changed in the last week or so? :thinking: Specifically: GET /admin/users/list/all.json?email=email@example.com :thinking: I think this endpoint used …

Hi, yes sorry this shouldn’t have been merged, it was my mistake. But the good news is that I already reverted it 8 hours ago: DEV: revert admin users list change (#32723) · discourse/discourse@7558e2c · GitHub

Nooooo way… :scream: Well, that’s what I learnt today! Thanks @RGJ :clap:t2::star_struck:

I managed to find that commit somehow, but couldn’t (and still don’t) see where it changed the data structure (I was on my phone, making things a bit more difficult).

I’m guessing this was the breaking change in the API response :confused: In /app/assets/javascripts/admin/addon/controllers/admin-users-list-show.js [Screenshot 2025-05-11 at 15.36.17]

[圖片] pfaffman: where it changed the data structure It’s the line root: :users that was added.

We’ve now recovered from the impact of this change. Perhaps going a bit off topic here but is there a way I can track these types of updates so I can notify myself when an API response changes from “X”, after being “Y” for so many years? :thinking: Some kind of scripted local unit tests that I cou…

You could have a staging environment. You might also create a github action for your code that starts discourse and runs a test against the latest discourse each day.

[圖片] pfaffman: runs a test against the latest discourse each day Ah-ha! Perfect, that’d work, thanks :grin:

I think a plugin that called the endpoint and rendered it could be an easy way to test. And then change the default github action to run daily instead of only on push.

Seems the documentation needs an update as well https://docs.discourse.org/#tag/Admin/operation/adminListUsers In an ideal world, the documentation would be auto generated from the source and we could just look at the commit history for the documentation, which would only contain the changes in the…

[圖片] RGJ: Seems the documentation needs an update as well This is what caught me out too when trying to resolve the issues caused by this change :confused:

对 /admin/users/list/all.json API 响应结构的更改？

开发

pfaffman (Jay Pfaffman) 2025年五月11日 19:26 11

您可以设置一个暂存环境。您也可以为代码创建一个 GitHub Action，该 Action 每天启动 discourse 并针对最新的 discourse 运行测试。

話題		回覆	觀看
Cases when admin/users.json?email=foobar or admin/users/list/all.json?email=foobar return empty array Development rest-api , user-api	5	341	2025年四月29日
Issues with the /get-users ending point Development rest-api	4	175	2024年七月16日
How do I get a list of all users from the API? Development rest-api	18	11331	2021年十二月24日
Creating users through RESTFUL Users API - Users.json got wiped Development rest-api	4	1767	2019年二月28日
Group API, empty response Development rest-api	6	940	2020年十一月9日

对 /admin/users/list/all.json API 响应结构的更改？

相關主題