"Thanks for Contributing" Popup in Posts Appearing Even After Limit Passed?

Hello! I just updated to Discourse v3.5.0.beta7 +123 according to the admin control panel (forgive me for being new to all of this, I have just started using Discourse over the past few days :grin:). I noticed recently that the ā€œthanks for contributingā€ dialog that appears to the right of the posting window no longer disappears for users who have passed the post limit (I believe 2 is the default). I set it to 0 so that the dialog is not displayed at all, but it would be nice to have for new users, if only I could fix this behaviour somehow! The problem seems to go away if you sign out and sign back in, I created a test account and the dialog would appear for every post that I made with that account, until I signed out and signed back in. At that point everything worked as expected. Very strange, perhaps someone else has seen this!

2 Likes

Just double checking, can anyone else reproduce this regression?

I have noticed that if the popup is enabled and a person is seeing it, logging out and logging back in seems to solve the problem (the popup no longer appears). I have just left them disabled for the moment, however :slight_smile:

Steps to reproduce

  • Register an entirely new account (do not create it via the admin interface).
  • Create some test posts. The default limit for the ā€œeducationā€ dialog is 2 posts, after which you should no longer see it.
  • The dialog continues to appear after the required number of posts.
  • Now log out and log back in. The dialog will no longer appear for that user.

Perhaps this will help someone else in reproducing :slight_smile: Sorry for ā€œbumpingā€ the post so to speak, but I thought the additional information might be helpful. I can also state that as of updating to v3.5.0.beta7 +139 the bug still appears to exist, at least on my end. I was also concerned that this may just have been a browser related hiccup (I normally use Safari), so I tried the reproducing steps with Firefox and the problem still occurred!

Hello and welcome @phoenix1 :slight_smile:

I managed a tentative repro earlier, but with the caveat that it only seemed to happen on the new topic education message and not the new post education message. Though it also stopped by itself rather than needing a logout/login. My test user saw the topic education message for their first 3 topics that went on to be published and then also in the draft of the fourth, but after trying to see if the post one would also do the same the topic one stopped showing.

2 Likes

Thanks very much, I appreciate it! :slight_smile: If there is any additional information that I can provide to help improve the report please let me know, I am pretty new to all of this so have not ruled out that I have made a silly mistake yet :stuck_out_tongue:

Thank you for reporting. I made some changes to simplify the post count as we were previously counting topics and posts separately.

I think this should solve it:

2 Likes

Is the message shown now the same?

I agree that the welcome part at the top was confusing after a year of participating. But I think even when the user has joined a while ago it still makes sense to tell them about choosing an interesting title.



Edit:
I just noticed the texts were changed 2 months ago.

Now they are much more alike, so it does not matter as much. But I think the detailed instructions were more interesting than the general ā€œplease read the guidelinesā€


2 Likes

Aren’t those separate counts needed for showing the right message? (Either education.new-topic or education.new-reply)

2 Likes

I would like to thank you very much for looking into this! :slight_smile: The post count change certainly does help, in that the topics and replies are both considered in the count now, so that took care of some buggy behaviour, excellent!

I must be doing something wrong though, if I take the following steps:

  • Register a new account manually (not through the admin interface)
  • Post several topics through that new account without logging out

In this particular case (and it is a particular one :slight_smile: ), the welcome dialog continues to appear no matter how many topics and replies are posted, at least in my testing. It does disappear once you logout and log back in, though. I think the reason I was seeing it more often than before was due to the bug you have fixed here, so it’s certainly improved upon the situation! :slight_smile:

3 Likes

No I don’t think so. The translation key hasn’t changed as far as I can tell.

Only the count value has changed to combine both topic count and post count.

2 Likes

I think I’m being a :derp: :slight_smile:

So, the education.new-topic still shows up for your first two topics, and education.new-reply still shows up for your first two ā€˜non-op’ posts?

2 Likes

I can reproduce that problem. The education message is shown even after the first two topics were created. It works when I create replies, but not for topics.

2 Likes

Thanks for testing this, I wasn’t sure if I might have just been using something incorrectly :slight_smile: I had also not tested it for replies, only for topics, so good idea there!

2 Likes