El error no se resalta cuando el nombre de usuario es correcto, pero la contraseña no tiene suficientes caracteres.

zogstrip · 12 Diciembre, 2025 21:23

Será corregido por

github.com/discourse/discourse

FIX: Show error highlighting on password field in finish installation form

main ← fix-ux-on-finish-installation-form

opened 09:22PM - 12 Dec 25 UTC

ZogStriP

+198 -120

When submitting the admin registration form with an invalid password (blank or t…oo short), the password field was not visually highlighted with the error state, making it unclear what was wrong. Two issues were causing this: 1. Copy-paste error: The password field container was checking `@user.errors[:username]` instead of `@user.errors[:password]` 2. Wrong error key: Password length validation errors from the UserPassword model are stored under `:"user_password.password"`, not `:password`. The template only checked the latter. Fixed by checking both error keys and displaying all password-related errors with proper visual highlighting. Added system spec with page object for UI behavior testing and trimmed request spec to cover edge cases that require stubs (like empty developer_emails). Ref - https://meta.discourse.org/t/381505 Here's how the errors look like **Blank username & blank password** <img width="1772" height="1274" alt="CleanShot 2025-12-12 at 22 01 03" src="https://github.com/user-attachments/assets/4a6a3628-7a9b-48ee-bf9e-f6b1baba9b90" /> **Username filled & blank password** <img width="1772" height="1274" alt="CleanShot 2025-12-12 at 22 01 18" src="https://github.com/user-attachments/assets/fdef8ad1-1aa9-4b12-90d8-aeccc8344fc0" /> **Username filled & short password** <img width="1772" height="1274" alt="CleanShot 2025-12-12 at 22 01 29" src="https://github.com/user-attachments/assets/2c1c96e4-e5d4-40af-8f33-30ca0e1aafc5" />

Me tomé el tiempo de aumentar la cobertura añadiendo también una especificación del sistema

Tema		Respuestas	Vistas
Optimization Proposal for Discourse Admin Account Registration Process UX	2	30	12 Diciembre 2025
关于我安装discourse之后，打开网页点击注册没有任何反应 Support	5	63	12 Diciembre 2025
Full name at Sign Up went missing Bug signup	28	333	11 Enero 2025
Signup error msg is confusing: "User password password is the same as your name" Bug	3	103	23 Diciembre 2024
Cant setup admin account Installation	9	1142	3 Agosto 2022

El error no se resalta cuando el nombre de usuario es correcto, pero la contraseña no tiene suficientes caracteres.

Temas relacionados