사용자 이름이 정상이지만 비밀번호가 너무 짧을 때 오류가 강조되지 않음

zogstrip · 12월 12, 2025, 9:23오후

다음 PR로 수정될 예정입니다.

github.com/discourse/discourse

FIX: Show error highlighting on password field in finish installation form (#36672)

main ← fix-ux-on-finish-installation-form

merged 09:10PM - 13 Dec 25 UTC

ZogStriP

+198 -120

When submitting the admin registration form with an invalid password (blank or t…oo short), the password field was not visually highlighted with the error state, making it unclear what was wrong. Two issues were causing this: 1. Copy-paste error: The password field container was checking `@user.errors[:username]` instead of `@user.errors[:password]` 2. Wrong error key: Password length validation errors from the UserPassword model are stored under `:"user_password.password"`, not `:password`. The template only checked the latter. Fixed by checking both error keys and displaying all password-related errors with proper visual highlighting. Added system spec with page object for UI behavior testing and trimmed request spec to cover edge cases that require stubs (like empty developer_emails). Ref - https://meta.discourse.org/t/381505 Here's how the errors look like **Blank username & blank password** <img width="1772" height="1274" alt="CleanShot 2025-12-12 at 22 01 03" src="https://github.com/user-attachments/assets/4a6a3628-7a9b-48ee-bf9e-f6b1baba9b90" /> **Username filled & blank password** <img width="1772" height="1274" alt="CleanShot 2025-12-12 at 22 01 18" src="https://github.com/user-attachments/assets/fdef8ad1-1aa9-4b12-90d8-aeccc8344fc0" /> **Username filled & short password** <img width="1772" height="1274" alt="CleanShot 2025-12-12 at 22 01 29" src="https://github.com/user-attachments/assets/2c1c96e4-e5d4-40af-8f33-30ca0e1aafc5" />

시스템 스펙을 추가하여 커버리지를 높이는 데 시간을 들였습니다

글		댓글	조회수
Optimization Proposal for Discourse Admin Account Registration Process UX	1	123	12월 12, 2025
关于我安装discourse之后，打开网页点击注册没有任何反应 Support	4	240	12월 12, 2025
Full name at Sign Up went missing Bug signup	27	623	1월 8, 2025
Signup error msg is confusing: "User password password is the same as your name" Bug	2	183	12월 19, 2024
Cant setup admin account Self-hosting	8	1331	8월 3, 2022

사용자 이름이 정상이지만 비밀번호가 너무 짧을 때 오류가 강조되지 않음

Related topics