尝试静默移动 Topics 到不同分类时意外的邮件/通知泛滥

zogstrip · 2025年十二月11日 11:39

哈哈！我想我发现问题所在了

FIX: silent option not working for bulk category moves via PostRevisor

Commit by

ZogStriP - DEV: improve topics_bulk_action_spec clarity and coverage

main ← dev-improve-topics-bulk-action-specs

The `silent` option for bulk category changes was not being respected when `crea…te_revision_on_bulk_topic_moves` was enabled. This caused users watching the destination category to receive notifications even when the "Perform this action silently" checkbox was checked. The bug was introduced in commit 7a099ebb6a which added `silent: @silent` to the `track_topic_field(:category_id)` block. However, since blocks capture `self` at definition time (the class, not the instance), `@silent` was always nil in that context. The fix passes the `silent` value through the `TopicChanges` object which is already available to the block as `tc`. Also extends test coverage to verify both topic watchers and category watchers are properly silenced in both code paths. Ref - meta/t/390993

@silent 选项没有正确传播，这导致关注目标分类的用户即使在选中“静默执行此操作”复选框时也会收到通知。

話題		回覆	觀看
Bulk editing topic categories should not trigger thousands of email notifications Feature completed , bulk-actions	12	1633	2025年七月30日
Moving old posts triggers email notifications Support	8	1037	2021年十一月5日
Any way to NOT send emails when a topic category is changed? Support	13	2299	2019年四月11日
Ability to move topics to new categories and suppress notifications Feature	9	472	2025年十一月21日
UI Bulk operations & Notifications Feature	0	820	2020年一月6日

尝试静默移动 Topics 到不同分类时意外的邮件/通知泛滥

相關主題