Dismissing upgrade available notifications leads to 422 errors

zogstrip · December 27, 2025, 11:00pm

Sorry about that @RBoy, we needed a little follow up to DEV: Remove admin notices when destroying problem check trackers

github.com/discourse/discourse

FIX: Dismissing admin notices fails with 422 when tracker has NULL target

main ← fix-dismissing-admin-notices-fails-with-422-when-tracker-has-null-target

merged 03:32PM - 29 Dec 25 UTC

ZogStriP

+45 -6

When dismissing an admin notice, the service would look up the associated `Probl…emCheckTracker` by identifier only. This could find a tracker with a `NULL` target, which then fails validation on update since target is now required (as of 8ca5fb706a). The root issue is that `problem_check_trackers.target` was added with `null: true` and while we later added a default value of `"__NULL__"` and a Ruby validation, we never enforced `NOT NULL` at the database level. This allowed records with `NULL` targets to persist or be recreated through code paths that explicitly passed nil. This commit: - Updates the dismiss service to look up trackers by both identifier AND target (extracted from the admin notice's details) - Removes any remaining records with `NULL` targets - Adds a `NOT NULL` constraint to prevent this from recurring Ref - https://meta.discourse.org/t/392248

Topic		Replies	Views
'Dimiss Unread' Button is broken on latest Bug	3	913	December 5, 2016
Production.log give No method error and Discourse not working Support	9	1230	January 9, 2020
Upgrade failed: null value in column "updated_at" violates not-null constraint Support	5	2644	August 10, 2017
Maybe a bug on meta, post disappeared Site feedback	26	5073	April 16, 2017
40 Fatals and 7 Errors in recent logs Support	13	1583	June 8, 2024

Dismissing upgrade available notifications leads to 422 errors

Related topics