Only posts with no likes or reactions can be "liked" in an archived topic

[NateDhaliwal]

I understand that posts in archived topic cannot be liked or reacted. On that basis, how come this post can be liked (in a sense that you can press the heart, although it throws a ‘That reaction was created too long ago. It can no longer be modified or removed.’ error, which also is not correct).

Actually, this applies to other posts in that topic. Though it seems posts with likes/recations cannot be liked at all, but those with none can be, albeit with that error thrown.

This inconsistent behaviour makes me think this should be in Contribute > Bug, perhaps?

[Moin]

I think it’s because of the reactions plugin. I cannot do the same in safe mode. And I remember accidentally adding a reaction to an archived post back when Jammy was the community moderator. Since my reaction was quite inappropriate, he removed it for me, and I think something was added to prevent that in the future. But I am not sure, and finding that in our chat will take very long.

[NateDhaliwal]

Alright. So in safe mode, the button cannot be pressed at all. I guess it should be hidden then on archived topics?

[Moin]

Looks like my problem occurred on posts that already had a like.

our conversation

Originally sent in JammyDodger

Moin

I tried how archiving which prevents likes and reactions work together.

The result: Button color changes - #7 by tyraniczar

I was able to add it, but I cannot remove it Now it will stay forever

JammyDodger

For this one, did you add the reaction before it was archived?

For me, it seems to block both adding and removing a reaction when archived (as expected)

Moin

I can still add to posts in that topic

JammyDodger

Ah yes. It says you can't, but you can

And no removal

Hmm

I unarchived it and tidied up the stray Reactions

I'll pop a report in

I'm getting some oddities in my repro for this archiving + reactions test

On my test site, the reactions menu doesn't show up

Only the

Moin

I can repro at my playground

JammyDodger

Hmm

• Create topic
• Add reply
• Archive
• As test user, visit topic and attempt to react to a post

Moin

Now It doesn't work there neither

JammyDodger

I tried on my Basic hosted site and that also does not work

Moin

When the test user creates the reply and I archive and react without a reload, adding the reaction works. But not after the refresh

Try liking the post as user2 before archiving and then react with as 3 afterwards

JammyDodger

Yes, I can repro with that

[zogstrip]

Thanks @NateDhaliwal & @Moin, looks like reactions had some wrong logic when it came to handling archived topics.

FIX: Prevent reactions on posts in archived topics (#39038)