Grid Lightbox-Bilder werden in falscher Reihenfolge angezeigt

zogstrip · 13. Mai 2026 um 09:16

Danke @Shauny für den Bericht. Das Debuggen und Beheben hat Spaß gemacht

github.com/discourse/discourse

FIX: Preserve original image order in grid lightbox (#39968)

main ← fix-grid-lightbox-order

opened 09:15AM - 13 May 26 UTC

ZogStriP

+174 -3

Inside a `[grid]` block, the lightbox arrow navigation followed column-balanced …DOM order instead of the original markdown order. For four images this resulted in 1, 3, 2, 4 because `Columns` distributes items by height into the shortest column. `lightbox.js` collects items via `querySelectorAll(".lightbox")`, which returns nodes in document order — the same scrambled order the layout algorithm produced. `Columns` now tags each item with `data-lightbox-position` carrying its original index before reordering. A new `sortLightboxItems` helper in `lightbox.js` reorders items within each grid by that attribute before they reach PhotoSwipe. The existing RTL reverse continues to apply on top, so right-to-left navigation now mirrors logical order rather than the scrambled layout. https://meta.discourse.org/t/402817

cc @davidb

Thema		Antworten	Aufrufe
Introducing image grids in posts Announcements new-feature	43	7509	10. Januar 2026
Image lightboxing does not respect manual resizing or [grid] tags Bug lightbox	5	322	2. Dezember 2024
Uploading images in order of filename Feature	31	1472	8. Oktober 2018
Lightboxed images do not have `vertical-align` set, misaligning them with naked `img`s Bug lightbox , fixed	3	265	22. Juni 2024
Image lightbox not working after collapsed Bug chat	5	647	15. April 2023

Grid Lightbox-Bilder werden in falscher Reihenfolge angezeigt

Verwandte Themen