Users are experiencing an issue when trying to add groups to messages using the @ symbol. The autocomplete function only accepts usernames, not group names. robmc pointed out that according to previous instructions, group mentions should be possible using the @ symbol.
sam called this a regression and asked joffreyjaffeux to look into it. However, joffreyjaffeux didn’t recall touching the related code. nbianca was then called in to investigate and discovered that the issue had been present since before version 1.8.
nbianca found that the problem was due to the query sent to the server, which included the @ symbol and worked for usernames but not groups. nbianca fixed the issue by adjusting the query sent to the server.
zogstrip suggested that the search data for groups should be implemented to allow for the same search functionality as usernames. However, nbianca didn’t think it was worth the effort at this time. zogstrip recommended that the server should still perform the same stripping for those calling the API directly.
nbianca replied that it’s actually the client’s responsibility to ask the correct questions to obtain the correct results.
When adding users to a new message, using the @ symbol searches only usernames, not groups.
Is this intentional? Looking back at previous instructions, it seems that we were encouraged to use the @
When trying to send a message to a group, where Everyone is allowed to mention and message the group, you are unable to add them. It appears that if you start with the @ symbol the autocomplete only accepts usernames, even if you add the full name of the group.
If you just enter text however, then the group names do appear
I tried to bisect this, but I had no luck… because this has been broken before v1.8! (I could not install older versions because I had problems with dependencies that were not worth the time)
Anyway, I got it fixed. The problem is that the query that gets to the server includes @ which seemed to work fine for usernames (Search.ts_query is pretty smart), but did not for groups.
Currently there is search data for users, topic, posts, categories and tags, but none for groups. Implementing it is definitely possible, but I do not think it is worth the effort.
At first I implemented the stripping on the server side, but then I realised it isn’t server’s fault. If the client wants correct results, they should ask the correct questions.
to 