Issues overriding getters in a controller (3.0.0)

merefield · January 16, 2023, 10:46pm

OK we’re even more sure of there’s an issue here… as mergeMixins is mentioned in the stack trace

Issue with `mergeMixins` when accessing a service in a getter

opened 06:29PM - 03 Apr 20 UTC

Recently found an issue with mergeMixins. it affects Ember versions at least as …far back as 3.12 and also current release and LTS. As I understand it, the issue is when a mixin defines a property (doesn’t necessarily have a value) then we try to access the value during construction before owner is set. This breaks getters that access services. Shared findings with @pzuraq. Error message: `Attempting to lookup an injected property on an object without a container, ensure that the object was instantiated via a container. Error: Assertion Failed: Attempting to lookup an injected property on an object without a container, ensure that the object was instantiated via a container.` [Code where issue arrises ](https://github.com/emberjs/ember.js/blob/v3.17.3/packages/@ember/-internals/metal/lib/mixin.ts#L475) (Please note: the original link was to `master` 😞. I've changed the tag to the version of ember published the day before, but I have no memory of the original code it linked to) [Reproduction](https://ember-twiddle.com/3147343e2dbf0e4c6965a50fa7e7389d?openFiles=controllers.application%5C.js%2C) ([Gist](https://gist.github.com/nlfurniss/3147343e2dbf0e4c6965a50fa7e7389d))

(thanks to @RGJ for finding this)

Topic		Replies	Views
Upgrading Ember to 2.10 Dev ember	71	10596	December 22, 2016
Beta upgrade failed: 3.1.0.beta8+248 > 3.2.0.beta1+15 Bug docker-manager	4	373	September 14, 2023
New installs will default to Ember CLI builds in Production Announcements ember	36	3352	June 17, 2022
Upgrade error for v3.2.0.beta3 Support two-container	1	442	November 13, 2023
Upgrading Discourse to Ember 4 Dev ember	13	2830	June 7, 2024

Issues overriding getters in a controller (3.0.0)

Related Topics