3.2.0.beta2-dev (7019dbcfe1) does not load CSS from common.scss anymore

[nodomain]

We have a custom theme and make use of CSS customizations using common.scss. It seems to have broken with the recent upgrade, e.g. styles defined in common.scss are not read anymore.

Can you please pinpoint me into any changes I need to make or fix this issue if it is a regression?

Thanks

[Lilly]

I cannot reproduce this. I am running 3.2.0.beta2-dev on two separate instances and the remote common.scss files for themes and components seem to be functioning as expected, as is the common css theme editor. Have you tried narrowing it down by disabling other components? Have you made any changes or added any components lately?

If you want to post a link to the theme repository, I can have a look and test it and perhaps see what the issue might be.

[nodomain]

Unfortunately the repo is internal, I am going to post a PM to you.

[Lilly]

Ok that was really odd and yes it appears that your instance of 3.2.0.beta2-dev has an issue reading private repo files, or at least the common.scss file. As soon as you reverted to beta1, the common.scss file was recognized and the formatting fixed. Something is definitely not working as expected there.

[nodomain]

As discussed via PM: we keep 3.2.0beta1 pinned for the time being until this is fixed.

Thanks for the quick help here

[nodomain]

For the record, somewhere in this time frame the issue was introduced:

Comparing a9cc379...7019dbc · discourse/discourse

Still investigating.

[Canapin (Coin-coin le Canapin)]

Hi nodomain, are you still using an unsupported install as stated here?

403 forbidden for thumbnails on s3 when running with CDN

That’s not official, as it’s an AWS project using a bitnami image for Discourse which we explicitly do not recognize as an official standard install of Discourse, making this outside of the scope of installs that we support here. Not a bug as it’s not running the app the way we intend it to be ran, but it may be fixed with a config change. Maybe open an issue about this on the sample repository ?

Just in case it would be useful information

[nodomain]

Yes but still using the official way of building the docker images myself. I just put the stuff on ECS etc.

The site breaks reproducibly when switching to the new version w/o changing anything else.

[nat (Natalie T)]

Hey there, can you try out a local install of discourse tests-passed, along with the discourse_theme CLI tool?

Install the Discourse Theme CLI console app to help you build themes

The [discourse] Discourse Theme CLI is a ruby gem that allows you to use your editor of choice when developing Discourse themes and theme components. As you save files the CLI will update the remote theme or component and changes to it will appear live! Installing To play with it, make sure you have Ruby 2.5 or up installed. [image] If you are on Windows, you have 2 options: Option 1: Windows Subsystem for Linux. Windows 10 has access to a full Linux environment, you can use it to instal…

Once installed, you can run discourse_theme watch <YOUR_THEME_FOLDER> and the watcher should be able to point out issues to you.

[nodomain]

Good idea, I’ll check this later and give feedback.

[nodomain]

Got it! It showed also up in the admin UI already. I have no idea why I did not see it yesterday morning

Error: “+” and “-” must be surrounded by whitespace in calculations. ╷ 1097 │ width: calc(100%- #{$grid_columns_2_width}); │ ^ ╵ /var/www/discourse/common.scss 1097:19 root stylesheet

Interestingly, this did not pose an issue with the previous version. So something seems to have changed to make scss parsing more strict?

After adding the required whitespace, everything looks great again.

Thank you so much.

[nat (Natalie T)]

@nodomain

So something seems to have changed to make scss parsing more strict

I can’t pinpoint the commit, but our team is currently prioritising making theming more stable and friendly. So these (linting) are probably first steps to ensuring stability.

Glad you found the issue!