Downloaded Two-Factor Backup Codes are not separated on Windows (only LF newline)

sebix1 · October 21, 2024, 5:20pm

The downloaded file generated by the Two-Factor Backup Codes function includes the 10 codes separated by an LF (\n) character.

Windows users will only see 320 characters in one line in this file instead of 10 separate codes.

The string with the backup codes is generated here:

github.com

discourse/discourse/blob/88449541a595514092b9d43640a47bd3e9dc601f/app/assets/javascripts/discourse/app/components/backup-codes.gjs#L41


      
          
          get base64BackupCode() {
            return b64EncodeUnicode(this.formattedBackupCodes);
          }
          
          get formattedBackupCodes() {
            if (!this.args.backupCodes) {
              return null;
            }
          
            return this.args.backupCodes.join("\n").trim();
          }
          
          @action
          copyToClipboard() {
            this._selectAllBackupCodes();
            const copied = copyText("", this.backupCodesArea);
            this.args.copyBackupCode(copied);
          }
          
          @action

Can we add a carriage return character too? For Linux/macOS users, this will make no difference in viewing the file, but it fixes the problem for Windows users.

I can also open a PR for this issue myself if that makes the implementation easier, but I want this to be reported and possibly discussed first.

pmusaraj · October 21, 2024, 7:16pm

Very reasonable suggestion, a PR would be most welcome. Thanks!

sebix1 · October 24, 2024, 7:33pm

Done: 2FA Backup Code Download: Use CRLF for Windows-compatibility by sebix · Pull Request #29400 · discourse/discourse · GitHub

pmusaraj · November 11, 2024, 8:17pm

Thanks @sebix1, we can’t merge your PR until you sign the CLA, though.

Topic		Replies	Views
Only 2 out of 10 backup codes visible when generated UX	3	792	January 24, 2020
2FA Backup codes Feature	9	2590	August 14, 2018
Admin locked out of site after deleting two-factor keys from prefs Bug	26	2142	December 8, 2022
Two Factor Backup Codes Announcements new-feature , 2fa	1	1638	December 1, 2023
Recovery codes for 2FA? Feature	3	1154	June 8, 2018

Downloaded Two-Factor Backup Codes are not separated on Windows (only LF newline)

Related topics