Server Error accessing topic revisions on a specific topic

zogstrip · November 30, 2024, 2:49pm

Thanks for the report @paulofonseca.eth, this will be fixed by

github.com/discourse/discourse

PERF: only diff HTML / Markdown when needed

discourse:main ← discourse:perf-posts-revisions

opened 02:48PM - 30 Nov 24 UTC

ZogStriP

+44 -33

When serializing the `body_changes` in the `PostRevisionSerializer`, we create t…wo diffs: one for the `cooked` and another one for the `raw` version of the post. Inside `DiscourseDiff`, we generate both `html` and `markdown` diffs when we only need the `html` diffs for the `cooked` version of the post and the `markdown` diff for the `raw` version of the post. This solves the issue repored in https://meta.discourse.org/t/server-error-accessing-topic-revisions-on-a-specific-topic/339185 where some revisions would return 500 because of a `ArgumentError : Attributes per element limit exceeded` exception when trying to generate the `html` diff on a very large `raw`.

Topic		Replies	Views
Internal Server Error after User is logged out by Admin Bug	6	1385	May 5, 2018
Reactions plugin: 500 Internal Server Error Bug reactions	9	487	October 28, 2022
500 Error when posting, moment.tz runtime error Bug	15	98	August 26, 2024
Page view reports: category dropdown does nothing, 500 Server error Bug	8	1671	May 9, 2016
Upcoming events shows 500 server error Bug calendar-and-event	13	1421	August 26, 2023

Server Error accessing topic revisions on a specific topic

Related topics