Server Error accessing topic revisions on a specific topic

zogstrip · November 30, 2024, 2:49pm

Thanks for the report @paulofonseca.eth, this will be fixed by

github.com/discourse/discourse

PERF: only diff HTML / Markdown when needed

discourse:main ← discourse:perf-posts-revisions

opened 02:48PM - 30 Nov 24 UTC

ZogStriP

+44 -33

When serializing the `body_changes` in the `PostRevisionSerializer`, we create t…wo diffs: one for the `cooked` and another one for the `raw` version of the post. Inside `DiscourseDiff`, we generate both `html` and `markdown` diffs when we only need the `html` diffs for the `cooked` version of the post and the `markdown` diff for the `raw` version of the post. This solves the issue repored in https://meta.discourse.org/t/server-error-accessing-topic-revisions-on-a-specific-topic/339185 where some revisions would return 500 because of a `ArgumentError : Attributes per element limit exceeded` exception when trying to generate the `html` diff on a very large `raw`.

Topic		Replies	Views
Unable to View Edit History - Continuous Loading Issue Support	15	122	August 1, 2024
Happening again: Revision is hidden/inaccessible Bug	0	43	April 5, 2025
Pull or quote content from within the revision history Dev rest-api	1	317	November 14, 2023
Title missing from revisions dialog Bug	2	850	March 2, 2015
Endless loading of post history when latest revision is hidden/inaccessible Bug fixed	10	510	August 30, 2024

Server Error accessing topic revisions on a specific topic

Related topics